Deprecations or clean sweep?

[byronka]

Hi all,

I'm trying to decide on which way to handle some upcoming changes.

I would like to improve code in FunctionalTesting which searches for HTML elements. Currently, a developer is able to search by a combination of the element type (like P, DIV, etc) and the attributes (class, id, etc) (See, for example, searchOne in FunctionalTesting).

But, there is no way to search purely by attributes (id = "foo") or purely by tag (VIDEO, etc.).

My first attempt to fix this was by adding more functions to FunctionalTesting to handle those cases. I reversed course when I realized I could add one single method, getAttributes in TagInfo, and empower users fully, and avoid needing to write so much code.

In the past, at this point I would remove all the previous code and only allow the new paradigm. This would constitute breaking changes, and necessitate a new version (v9). But then, I could deprecate the old way of doing this but leave it in the codebase, pointing at the new approach, which is maybe gentler.

So that brings me to the question: Who out there is using Minum, and are you using the search functionality in FunctionalTesting? Is it better that I deprecate the old code but leave it in for now, or should I do a clean sweep and only leave the revised code, thus causing breaking changes? Just looking for opinions. Thanks!