Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Role "grid" is used inappropriately in the simple "list" component #1657

Open
MarcoZehe opened this issue May 25, 2021 · 3 comments

Comments

@MarcoZehe
Copy link

Bug Report

If an app uses the list component from react-virtualized, the ARIA markup is incorrect. There is a "grid" container, but no "row" children and "gridcell" grandchildren. Screen readers of all platforms get utterly confused, report a grid with 0 rows, and on Mac, VoiceOver even doesn't render any of the child components, making apps largely inaccessible.

What is the current behavior?

Inaccessible apps due to invalid markup. Grid containers end up with button children or such.

Examples: Signal-Desktop, DeltaChat, Facebook Messenger.

What is the expected behavior?

List should use a generic container role like "region" instead, since you don't know what children there could be. Normally, "listbox" would be appropriate, but that requires that the children be of role "option". Since unlike with grids, you don't populate list children with default roles, this cannot be guaranteed, so for best generic accessibility, "region" is probably the best role to use here.

Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser Several
OS Mac, Win
React Several
React DOM Several
react-virtualized Several
@nattri
Copy link

nattri commented Jul 8, 2021

Facing the same issue. This makes all list items inaccessible to the voiceover when using accessibilities keys like ctrl+option+ right/left arrow.

@nattri
Copy link

nattri commented Aug 12, 2021

@bvaughn @TrySound Can we please merge this PR - #1673 to fix current thread.

@ericbf
Copy link

ericbf commented Oct 4, 2023

Two years down the line and this is still an issue? What’s the hold up here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants