Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation request for required dependencies #18

Open
Crecket opened this issue May 8, 2018 · 1 comment
Open

Add installation request for required dependencies #18

Crecket opened this issue May 8, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request Pending PR Changes
Milestone

Comments

@Crecket
Copy link

Crecket commented May 8, 2018

When a dependency is detected as missing it should ask the user if the dependency should be installed with the default installation command instead of simply exiting the setup script.

For composer the php-mbstring and php-curl packages are also required which are currently not checked yet

Crecket added a commit to Crecket/tinker_php that referenced this issue May 8, 2018
@OGKevin
Copy link
Contributor

OGKevin commented May 9, 2018

@Crecket please include all the extensions listed in composer json. Could you also inlcude a check for php version if its not there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Pending PR Changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants