DraftPaymentCreate - Serialization of Pointer object - throws Token PropertyName in state Property would result in an invalid JSON object. when using custom JsonConverter<T>

[Tieno]

Steps to reproduce:

1. Try to create a draftpayment

What should happen:

1. DraftPayment is created

What happens:

1. Throws exception Token PropertyName in state Property would result in an invalid JSON object. when using custom JsonConverter

Extra info:

[//]: # https://stackoverflow.com/questions/54441810/token-propertyname-in-state-property-would-result-in-an-invalid-json-object-whe

Error is located in BunqSdk/Json/MonetaryAccountReferenceConverter.cs

writer.WriteRaw(BunqJsonConvert.SerializeObject(monetaryAccountReference.Pointer));

should be changed to

writer.WriteRawValue(BunqJsonConvert.SerializeObject(monetaryAccountReference.Pointer));

Like below

/// <summary>
    /// Custom (de)serialization of MonetaryAccountReference required to provide compatibility between the two types
    /// used to refer to Monetary Accounts: Pointers in requests and Monetary Account Labels in responses.
    /// </summary>
    public class MonetaryAccountReferenceConverter : JsonConverter
    {
        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
        {
            var monetaryAccountReference = (MonetaryAccountReference)value;

            if (monetaryAccountReference == null || monetaryAccountReference.Pointer == null)
            {
                writer.WriteNull();
            }
            else
            {
                     writer.WriteRawValue(BunqJsonConvert.SerializeObject(monetaryAccountReference.Pointer));
            }
        }

        public override object ReadJson(JsonReader reader, Type objectType, object existingValue,
            JsonSerializer serializer)
        {
            var jObject = JObject.Load(reader);
            var labelMonetaryAccount = BunqJsonConvert.DeserializeObject<LabelMonetaryAccount>(jObject.ToString());

            return new MonetaryAccountReference(labelMonetaryAccount);
        }

        public override bool CanConvert(Type objectType)
        {
            return objectType == typeof(MonetaryAccountReference);
        }
    }

[aimi-theo]

Is this issue solved at the end? I am still receiving the same error :/

[two-trick-pony-NL]

👋 Hey @Tieno @aimi-theo

I work at bunq and am currently reviewing the bunq API docs, open issues and SDK’s and came across your issue. I know it’s been open for a while, and I’d love to understand how it’s impacting you. Beyond the obvious -fixing this issue-, what else could we do to improve your experience with our API?

If you want to share your thoughts on how we can improve on our public API:

📅 I'd love to schedule a 15 minute interview to understand your needs through: Calendly
💬 Or if you don't have time for a call, you can give us some general feedback through this form

Your feedback will go straight to our product team! 🚀

[two-trick-pony-NL]

Hi! We're closing this issue as it's tied to an older version of our SDKs, and we've since completely revamped them as part of bunq Update 28.

This is a fresh start—we've tested the new SDKs extensively, and we’ll be putting them to the test again during our upcoming hackathon this Friday, where we’ll fix idiosyncrasies on the spot. (You’re welcome to join us!)

If this issue (or a new one) shows up with the updated SDKs, feel free to reopen or file a new report—we're happy to jump on it.