Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow to modify nginx default buffer setting to handle "upstream sent too big header" #897

Open
1 task done
chrismade opened this issue Jan 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@chrismade
Copy link

What's needed and why?

I came across this issue earlier in the combination bunkerweb+keycloak - and see it now again in the combination bunkerweb+mailcow - nginx has some default buffer setting which are exceeded in some cases (like the ones mentioned - and there are likely a few more which just has not discovered yet) -
bunker has a setting already for REVERSE_PROXY_BUFFERING=yes but it might also be required to change the count and sizes of the buffers - for which I have not yet found anything in UI to change the setting or anywhere else in the documentation.

in bunkerweb < 1.5.0 I changed settings by adding a file in configs/http/proxybuffers.com like this

proxy_buffer_size   128k;
proxy_buffers   4 256k;

but I'm not sure if this is still the intended way to make changes in bunkerweb > 1.5.0 or if it even cause more harm than good to make changes directly in nginx configs - hence I would prefer either an "official" documented procedure for these changes or ideally option to make such changes in the config UI or variables.

Implementations ideas (optional)

I assume not much code needs to be developed from scratch - UI settings and variables already exist for REVERSE_PROXY_BUFFERING=yes/no and we just need to more variables (and their respective UI components + regex for checking) to allow users to modify the default buffers if they run across the "upstream sent too big header" in their specific application(s)

here I found more background why this is needed:
mailcow/mailcow-dockerized#4537
and here (with hints for k8s implementation):
https://stackoverflow.com/questions/57503590/upstream-sent-too-big-header-while-reading-response-header-from-upstream-in-keyc

Code of Conduct

  • I agree to follow this project's Code of Conduct
@chrismade chrismade added the enhancement New feature or request label Jan 31, 2024
@TheophileDiot
Copy link
Member

Hi @chrismade, custom configurations are still available in BunkerWeb 1.5.X
https://docs.bunkerweb.io/latest/quickstart-guide/#custom-configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants