Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add the possibility to upload custom certificates through the UI #642

Open
1 task done
0FiRE0 opened this issue Sep 17, 2023 · 5 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request v2

Comments

@0FiRE0
Copy link

0FiRE0 commented Sep 17, 2023

What's needed and why?

Currently, in the "Self-Signed Certificate" configurations from the UI, there is one option to generate a certificate (as per the screenshot below).

But there is no option to upload a certificate/key by the user, as in some cases the user might have a pre-generated signed certificate, either self-signed or signed by a custom CA or so.

Please add the option to upload a certificate, key, and certificate chain (optional).

image

Implementations ideas (optional)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@0FiRE0 0FiRE0 added the enhancement New feature or request label Sep 17, 2023
@TheophileDiot
Copy link
Member

Hi @0FiRE0, thank you for opening this feature request. Are you referring to the already existing custom certificate feature ? https://docs.bunkerweb.io/testing/settings/#custom-https-certificate

@0FiRE0
Copy link
Author

0FiRE0 commented Sep 18, 2023

Hi @TheophileDiot ,
Thank you for your swift feedback.
Correct, I am referring to the custom certificate, as currently it is only configurable through the config files, but missing in the Web UI.

@0FiRE0
Copy link
Author

0FiRE0 commented Sep 18, 2023

Also as an enhancement to the existing custom certificate configs in the link https://docs.bunkerweb.io/testing/settings/#custom-https-certificate

Currently, it does not support including the intermediate certificate chain (an optional attribute), where it is being used in the case the custom certificate does not include the full chain to the CA and it needs to be included separately.

@fl0ppy-d1sk
Copy link
Member

Also as an enhancement to the existing custom certificate configs in the link https://docs.bunkerweb.io/testing/settings/#custom-https-certificate

Currently, it does not support including the intermediate certificate chain (an optional attribute), where it is being used in the case the custom certificate does not include the full chain to the CA and it needs to be included separately.

You will need to create a bundle file instead of just using the end-user certificate file in CUSTOM_SSL_CERT.

More info here : https://nginx.org/en/docs/http/configuring_https_servers.html#chains

@0FiRE0
Copy link
Author

0FiRE0 commented Sep 18, 2023

Thank you @fl0ppy-d1sk for your feedback.

@TheophileDiot TheophileDiot changed the title [FEATURE] Use pre-generated self-signed certificate [FEATURE] Add the possibility to upload custom certificates through the UI Sep 20, 2023
@fl0ppy-d1sk fl0ppy-d1sk added the v2 label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2
Projects
None yet
Development

No branches or pull requests

4 participants