Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is wrong about initial setup #268

Open
payne911 opened this issue Dec 9, 2019 · 0 comments
Open

README.md is wrong about initial setup #268

payne911 opened this issue Dec 9, 2019 · 0 comments

Comments

@payne911
Copy link

payne911 commented Dec 9, 2019

Currently using v1.2.48.

We are advised to start with RestCredentials creds = new BullhornRestCredentials();, but it doesn't work.

In fact, BullhornRestCredentials does not implement RestCredentials and thus this operation is illegal in Java.

The solution for the users of this library is quite trivial: BullhornRestCredentials creds = new BullhornRestCredentials();. But that's not really idea.

This should be a fairly easy fix in the codebase which would be backward compatible with the current state of things. I just thought I'd let you know so that you can update either the README or the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant