Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the source fetchers #1473

Open
chenbh opened this issue Jan 8, 2024 · 0 comments
Open

Refactor the source fetchers #1473

chenbh opened this issue Jan 8, 2024 · 0 comments

Comments

@chenbh
Copy link
Contributor

chenbh commented Jan 8, 2024

Right now pkg/registry/fetch.go is in a bit of a weird place - it abstracts away the actual fetching of the image to an interface and doesn't interact with the other components of the same package.

I ran into this when I wanted to import a CNB-related constant into the registry fetcher, it fell into an import cycle of pkg/registry -> pkg/cnb -> pkg/dockercreds -> pkg/registry. Maybe I could've created a pkg/cnb/consts package for all the constants, but I feel that registry.Fetcher has fundamentally different uses than registry.Client, registry.KeychainFactory, and registry.Resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant