Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using v1.ObjectReference in kpack types #1139

Open
chenbh opened this issue Feb 8, 2023 · 0 comments
Open

Stop using v1.ObjectReference in kpack types #1139

chenbh opened this issue Feb 8, 2023 · 0 comments

Comments

@chenbh
Copy link
Contributor

chenbh commented Feb 8, 2023

example

We should stop using v1.ObjectReference embeds in our types as they contain way more fields than needed.

For example, we can fill in namespace, resourceVersion, and uid and they'll actually get persisted even though we don't use them at all

apiVersion: kpack.io/v1alpha2
kind: Builder
metadata:
  name: my-builder
spec:
  stack:
    name: bionic-stack
    kind: ClusterStack
    namespace: default
    resourceVersion: "74709881"
    uid: 811bec3c-f527-4e12-b3bd-d7837c331d81
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant