Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the outdated "implementation agreement" comment lines from the schema #256

Closed
pasi-paasiala opened this issue Mar 8, 2024 · 5 comments
Assignees
Milestone

Comments

@pasi-paasiala
Copy link
Contributor

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

Here are still the lines, if the line number mentioned above doesn't work due to changes to the file:

		<!-- Please note there is an implementation agreement on the use of minOccurs and maxOccurs.
			Valid values are: 
			a. 0 to unbounded, meaning Optional
			b. 1 to unbounded, meaning Required
			c. 0 to 0, meaning Prohibited
		 -->
@pasi-paasiala
Copy link
Contributor Author

Also the first line:

<!-- Draft - Do not use in production -->

should be removed.

@CBenghi
Copy link
Contributor

CBenghi commented Mar 24, 2024

Hi @pasi-paasiala,
we will remove the draft comment when freezing and updating the version number. Is that ok?

@CBenghi CBenghi added this to the 1.0 milestone Mar 24, 2024
@CBenghi CBenghi self-assigned this Mar 24, 2024
@CBenghi
Copy link
Contributor

CBenghi commented Mar 24, 2024

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

@pasi-paasiala
Copy link
Contributor Author

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

True. I didn't realize that this was a recent change.

@berlotti
Copy link
Member

berlotti commented Jun 3, 2024

fixed

@berlotti berlotti closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants