Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default units for measurements: missing definitions for IfcThermalTransmittance and others #242

Open
MatthiasWeise opened this issue Feb 5, 2024 · 3 comments
Assignees
Milestone

Comments

@MatthiasWeise
Copy link

Check of values such as "[20<=Value<=100]" requires to know the unit for a given measurement (meter for length, kg for mass etc.).
My understanding is that this unit is documented here: https://github.com/buildingSMART/IDS/blob/master/Documentation/units.md
Some measurements such as IfcThermalTransmittance are however missing.
Is it fair to assume that SI-base units are always used?

@CBenghi
Copy link
Contributor

CBenghi commented Feb 5, 2024

It's fair, but if you can add the row to the document, there's an automation process that reuses it for the audit tool.
PRs are welcome for this kind of issue.

@CBenghi CBenghi added the Please contribute A PR is welcome for this issue. Please target the `development` branch. label Feb 5, 2024
@CBenghi CBenghi added this to the 1.0 milestone Feb 5, 2024
@MatthiasWeise
Copy link
Author

We are running into a similar situation and struggle to use this table in our tool. As the datatype is something like IfcLengthMeasure we tried to show the unit from the "Unit Symbol" column.
Beside missing measurments like IfThermalTransmittanceMeasure there are also measurements like IfcPositiveLengthMeasure where underlying unit is part of the table but there we need to manage such Measurement - Unit relationship in a separate table.

When this table was discussed the idea was (if I remember well) to focus on most frequently used measurements. Meanwhile I doubt that this is really needed (@Pasi and @ Jiri Hietanen: please double check from your side) .
Some questions to the group before going ahead:

  • Do we still want to limit the scope of supported measurements/units in IDS or should we allow all from IFC? BTW: Current documentation is not really clear about that.
  • If we still want to limit the scope, my assumption is that this is for value comparison only (not for stating existence requirements).

I am in favor of supporting all measurements and propose to use the table from the IFC documentation (see this CSV: UnitMeasurement.csv). It does not include the dimensional exponents, but I wonder if we need that information here.
One difference I noticed is for Ration measure, which in our table is in [%].

If we want to keep the limitation, I would at least propose to extend IfcThermalTransmittanceMeasure:

| IfcThermalTransmittanceMeasure | Rate at which energy is transmitted through a body | | W / m2 K | (0, 1, -3, 0, 1, 0, 0) | IfcDerivedUnitEnum.THERMALTRANSMITTANCEUNIT |

@CBenghi
Copy link
Contributor

CBenghi commented Feb 26, 2024

Hello @MatthiasWeise, I've taken a list of measures from the schemas and updated the markdown file of units. Have a look.

@CBenghi CBenghi removed the Please contribute A PR is welcome for this issue. Please target the `development` branch. label Feb 27, 2024
@CBenghi CBenghi assigned CBenghi and MatthiasWeise and unassigned CBenghi Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants