Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] bb login should say it's going to open a webpage before doing so #6469

Open
brentleyjones opened this issue Apr 30, 2024 · 1 comment
Assignees

Comments

@brentleyjones
Copy link
Contributor

brentleyjones commented Apr 30, 2024

Is your feature request related to a problem? Please describe.

Currently bb login immediately opens a web page. This is jarring. gh auth login waits for the user to press Enter before opening the webpage:

$ gh auth login
? What account do you want to log into? GitHub.com
? What is your preferred protocol for Git operations on this host? SSH
? Upload your SSH public key to your GitHub account? /Users/brentley.jones/.ssh/id_ed25519.pub
? Title for your SSH key: GitHub CLI
? How would you like to authenticate GitHub CLI? Login with a web browser

! First copy your one-time code: XXXX-XXXX
Press Enter to open github.com in your browser...

Describe the solution you'd like

Something this this output:

$ bb login
We need your personal API key. Please log in to https://app.buildbuddy.io/settings/cli-login and copy your API key, creating one if needed.
Press Enter to open https://app.buildbuddy.io/settings/cli-login in your browser...
@sluongng
Copy link
Contributor

sluongng commented May 1, 2024

I think letting the user know and trigger the open with Enter makes a lot of sense. It's a great UX improvement and makes the CLI more predictable.

I am adding initial support for it in #6472. I will add the full message in a different PR so that folks could comment on the exact content to be displayed.

Great suggestion!

@sluongng sluongng self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants