Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS in plugins using React WSGI does not work #7444

Open
YngveNPettersen opened this issue Feb 18, 2024 · 0 comments
Open

JS in plugins using React WSGI does not work #7444

YngveNPettersen opened this issue Feb 18, 2024 · 0 comments
Labels

Comments

@YngveNPettersen
Copy link
Contributor

We have several WSGI plugins in our Buildbot configuration that have a JS script section. At least two of these plugins are showstoppers for a version update, if they do not work.

When configuring these plugins(one of which is an implementation of #4082) for React in 3.11 the script section is not parsed, and cannot be executed.

I asked one of my colleagues to debug, and the verdict was that React load the source of the App as innerhtml and that prevents JS execution in script tags.

The only available method my colleague is aware of to get this working is to use componentDidMount, but AFAICT there is no way to use that with the react WSGI dashboard component.

I see that buildbot have a smokes-react test app with a similar layout of the HTML file, so assuming it really works, I am unable to figure out why that should be working, and why mine isn't (and I did notice that there were changes made in the directory post-3.11, and I can't figure out how it can possibly work after those changes).

@p12tic p12tic added the bug label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants