Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder objects should have sort key member #7433

Open
YngveNPettersen opened this issue Feb 14, 2024 · 0 comments
Open

Builder objects should have sort key member #7433

YngveNPettersen opened this issue Feb 14, 2024 · 0 comments
Labels

Comments

@YngveNPettersen
Copy link
Contributor

I am presently updating our buildbot version to 3.11, and I am transferring our angularJS patches to react.

While doing that I discovered that, apparently, the <td key=foo> sort key does not work, the entries in e.g. the builders list are displayed in the sequence they were retrieved from the DB (which appears to be alphabetic).

We have a code segment in www/react-base/src/components/BuildersTable/BuildersTable.tsx that creates a sort key based on what type of builder category the builder is, e.g. normal builders in one section, testers in another, official builders in a third. Inserting this information into the key element does not work. My guess is that something is missing in the react code setting up the table.

However, there is no reason that the sort key should be recalculated every time the table is generated. It should be possible to add it to the builder object when they are created during the buildbot.tac configuration step, with the builder name being the default.

@p12tic p12tic added the bug label Feb 23, 2024
YngveNPettersen added a commit to YngveNPettersen/buildbot that referenced this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants