Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subprojects #88

Open
mrexodia opened this issue Feb 7, 2023 · 1 comment
Open

Support subprojects #88

mrexodia opened this issue Feb 7, 2023 · 1 comment
Labels
feature New feature

Comments

@mrexodia
Copy link
Contributor

mrexodia commented Feb 7, 2023

Currently a [project] causes automatic regeneration to stop (for consistency reasons, you don't want to regenerate another cmkr project's files). Can be solved like this:

[project]
name = "root"

[subdir.project1]
[project]
name = "project1"
subproject = true
parent = "root"

Either the subproject or the parent project could make it so root would work. The downside of using subproject is that accidentally setting it in a root project would falsely cause regeneration across different repositories.

@mrexodia mrexodia added the feature New feature label Feb 7, 2023
@mrexodia
Copy link
Contributor Author

mrexodia commented Mar 25, 2023

A related issue is where you include a subdirectory of another project (without including the subproject itself):

Root cmake.toml:

[project]
name = "root"

[subdir."subproject/lib"]

In this case subproject/cmake.toml is never encountered, so subproject/lib/CMakeLists.txt will be regenerated, which is a bug.

Actually it looks like this case is handled properly, but some testing is needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Development

No branches or pull requests

1 participant