-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: support clean shutdown also on SIGTERM #736
Comments
Hi @rwalkerands, thanks for reporting. I'm not sure what is the problem. In my understanding, SIGINT is needed for script server only to ask confirmation from a user. |
I'm getting this:
|
docker/podman stop script-server
sends firstSIGTERM
, then, after a timeout,SIGKILL
.script-server
seems to ignoreSIGTERM
, sodocker/podman
sends SIGKILL after the timeout.I see that
./src/web/server.py/intercept_stop_when_running_scripts()
configures a handler for SIGINT that will do a clean shutdown as long as there are no currently-running scripts.Would it be possible to do a clean shutdown on SIGTERM also? It could be like the existing behaviour for SIGINT except (I guess) acting as though the user answered
n
to the questionDo you want to stop server anyway?
.The text was updated successfully, but these errors were encountered: