perf(plugin-angular): do not run change detections when notifying the event #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
changed the title
|
Hey @arturovt thanks for the PR, we'll review as priorities allow :) |
|
@xander-jones friendly ping :) |
|
Hi @arturovt This is still on our radar but when we reviewed your PR the conclusion was that we wouldn't be able to accept it for the time being. We're considering an alternative implementation which would cover handled as well as unhandled events. We'd also need to treat this as a breaking change in case we have any customers relying on aspects of the existing behavior so we're looking to address this as part of our next major release. Thanks again for the contribution and we'll post on this thread with any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular runs 10 change detection cycles if the
notify()method is called within the Angular zone. This drastically affects the performance since we actually shouldn't run those change detections when notifying error events.This PR adds an ability to avoid running unwanted change detections when notifying the event.