feat(react-native): support for starting native spans on ios #540
+117
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
requested review from
gingerbenw,
lemnik and
robert-smartbear
Browser bundle sizeNPM build
CDN build
Code coverageCoverage values did not change👌. Total:
Generated against 5979437 on 4 December 2024 at 12:22:19 UTC |
yousif-bugsnag
force-pushed
the
PLAT-12937/start-native-spans-cocoa
branch
from
85ddc0d to
1b366b1
Compare
yousif-bugsnag
force-pushed
the
PLAT-12936/start-native-spans-android
branch
2 times, most recently
from
42f08bd to
1b8f00e
Compare
Base automatically changed from
PLAT-12936/start-native-spans-android
to
integration/rn-native-integration
December 2, 2024 14:56
An error occurred while trying to automatically change base from
PLAT-12936/start-native-spans-android
to
integration/rn-native-integration
December 2, 2024 14:56
yousif-bugsnag
force-pushed
the
PLAT-12937/start-native-spans-cocoa
branch
from
1b366b1 to
7373858
Compare
yousif-bugsnag
force-pushed
the
PLAT-12937/start-native-spans-cocoa
branch
from
adef590 to
e84642f
Compare
This reverts commit e84642f.
yousif-bugsnag
force-pushed
the
PLAT-12937/start-native-spans-cocoa
branch
from
ce38a1b to
6cc9a9d
Compare
yousif-bugsnag
force-pushed
the
PLAT-12937/start-native-spans-cocoa
branch
from
6cc9a9d to
5979437
Compare
gingerbenw
reviewed
Dec 9, 2024
Comment on lines
+152
to
+156
| NSMutableDictionary *span = [NSMutableDictionary new]; | ||
| span[@"name"] = nativeSpan.name; | ||
| span[@"id"] = [NSString stringWithFormat:@"%llx", nativeSpan.spanId]; | ||
| span[@"traceId"] = [NSString stringWithFormat:@"%llx%llx", nativeSpan.traceId.hi, nativeSpan.traceId.lo]; | ||
| span[@"startTime"] = [NSNumber numberWithDouble: [nativeSpan.startTime timeIntervalSince1970] * NSEC_PER_SEC]; |
There was a problem hiding this comment.
do we also need to add the first class property, or does that only matter for the native side?
| @@ -381,7 +381,7 @@ function installCocoaPerformance() { | |||
| const podfilePath = resolve(fixtureDir, 'ios/Podfile') | |||
| let podfile = fs.readFileSync(podfilePath, 'utf8') | |||
|
|
|||
| const performancePod = `pod 'BugsnagPerformance', :git => 'https://github.com/bugsnag/bugsnag-cocoa-performance.git', :branch => 'integration/react-native-integration'` | |||
| const performancePod = `pod 'BugsnagPerformance', :git => 'https://github.com/bugsnag/bugsnag-cocoa-performance.git', :branch => 'ya/crosstalk-api-startspan-improvements'` | |||
There was a problem hiding this comment.
I'm sure you won't miss it, but just a reminder to update this branch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add support for starting native spans on iOS - this is the iOS implementation of the
startNativeSpanTurbo Module method added in #536Design
The Turbo Module method startNativeSpan starts a span in Cocoa Performance via the CrossTalk API method
startSpanV1- this method accepts a span name as anNSStringand a set of span options as anNSDictionaryUpdated the Turbo Module Spec to use the
UnsafeObjecttype for native span options - this is required for backwards compatibility with the Old Architecture (otherwise codegen will generate a struct for the typed function parameter instead of usingNSDictionary)Testing
Tested manually as this isn't used yet