You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to use scalapb-generated code, one needs a scalapb-generated class for all the dependent protos. Depending on protovalidate-java as the source of protos won't work, even if one can use the library for validation.
Proposed implementation or solution:
Add protovalidate-java as a dependency in scalapb/common-protos.
Contribution:
I might just do it myself, but I don't know when I'll get to it. I'm currently working around it by vendoring the protos and just generating code for them directly.
Feature description:
Update https://github.com/scalapb/common-protos to include the
protovalidate
protos, not (only) theprotoc-gen-validate
protos.Problem it solves or use case:
In order to use scalapb-generated code, one needs a scalapb-generated class for all the dependent protos. Depending on
protovalidate-java
as the source of protos won't work, even if one can use the library for validation.Proposed implementation or solution:
Add
protovalidate-java
as a dependency in scalapb/common-protos.Contribution:
I might just do it myself, but I don't know when I'll get to it. I'm currently working around it by vendoring the protos and just generating code for them directly.
Examples or references:
The pgv protos are added to scalapb/common-protos in https://github.com/scalapb/common-protos/blob/e4e0254817d801a009d63b1e51be81b0f1f00b63/build.sbt#L32
The text was updated successfully, but these errors were encountered: