Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound transmute in safe method #274

Open
shinmao opened this issue Jun 12, 2023 · 0 comments
Open

Unsound transmute in safe method #274

shinmao opened this issue Jun 12, 2023 · 0 comments

Comments

@shinmao
Copy link

shinmao commented Jun 12, 2023

pub fn as_object_id(&self) -> &ObjectId {
unsafe { std::mem::transmute::<&ChunkId, &ObjectId>(&self) }
}

The safe method as_object_id used transmute to convert &ChunkId to &ObjectId. When we use transmute on reference, we need to ensure the layout (e.g., size and alignment) by ourselves. Even though ChunkId and ObjectId have the same type definition, rust compiler preserves the right to reorder and add padding bytes to the struct of repr(Rust) representation. Suggest to add repr(C) to both struct to make this guarantee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant