Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When start dec app service error ,app-manger auto retry 4 times #212

Closed
lizhihongTest opened this issue Apr 14, 2023 · 3 comments
Closed
Labels
App-Manager The App Manager basic service invalid This doesn't seem right question Further information is requested

Comments

@lizhihongTest
Copy link
Collaborator

Describe the bug
When start dec app service error ,app-manger auto retry 4 times. And it took me 5 minutes to find out that the startup failed, which is an ineffective retry mechanism and delays the time when the error is thrown
To Reproduce

  • Install cyfs://5r4MYfFJ7ktzBzSi1sWmU7BJLgpEEdp8ukbWemsFuQc1/9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5
  • The dec app service start will auto exit
Line 1033: [2023-04-14 19:29:41.894949 +08:00] INFO [ThreadId(26)] [service\app-manager\src\app_manager_ex.rs:660] [RUNNING CHECK] app status is running, but not actually. will restart it, app:9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5, retry count:1
Line 1185: [2023-04-14 19:30:41.896231 +08:00] INFO [ThreadId(35)] [service\app-manager\src\app_manager_ex.rs:660] [RUNNING CHECK] app status is running, but not actually. will restart it, app:9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5, retry count:2
Line 1337: [2023-04-14 19:31:41.896965 +08:00] INFO [ThreadId(28)] [service\app-manager\src\app_manager_ex.rs:660] [RUNNING CHECK] app status is running, but not actually. will restart it, app:9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5, retry count:3
Line 1489: [2023-04-14 19:32:41.897399 +08:00] INFO [ThreadId(23)] [service\app-manager\src\app_manager_ex.rs:660] [RUNNING CHECK] app status is running, but not actually. will restart it, app:9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5, retry count:4
Line 1653: [2023-04-14 19:33:41.898762 +08:00] INFO [ThreadId(28)] [service\app-manager\src\app_manager_ex.rs:654] [RUNNING CHECK] app failed count is out of limit! app:9tGpLNnYJZrs4woomnUf3QoadQgZQV6HjwoN5WPUpjH5, change app status from [Running] to [RunException]

Expected behavior
The retry mechanism is only used to recover from system abnormal interruption, not to increase retry in the normal process. This retry has no practical significance and will only increase the burden for users.

System information
OOD Service :
app-manager_31752_rCURRENT.log
1.0.1.750

@lizhihongTest lizhihongTest added bug Something isn't working App-Manager The App Manager basic service labels Apr 14, 2023
@weiqiushi
Copy link
Member

This is a useful logic because AppManager uses periodic detection after starting a DecApp Service to determine whether this Service is started successfully. If the start-up is judged as failed for N times in a row, this App is judged as RunException and no more attempts are made to start the Service.

This N value is part of the internal logic of AppManager, and the current N value is 5. DecApp developers should not be concerned about the specific value of this N value, but only need to know the logic of this decision.

@weiqiushi weiqiushi added invalid This doesn't seem right question Further information is requested and removed bug Something isn't working labels Apr 15, 2023
@weiqiushi
Copy link
Member

This N value is part of the internal logic of AppManager, and the current N value is 5. DecApp developers should not be concerned about the specific value of this N value, but only need to know the logic of this decision.

@lurenpluto
Copy link
Member

It seems to be related to the description of "retry count" in #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App-Manager The App Manager basic service invalid This doesn't seem right question Further information is requested
Projects
Status: 🚫Rejected
Development

No branches or pull requests

3 participants