ManuallySyncingCommandExecutor saving errors #441
Closed
daniil1112
started this conversation in
General
Replies: 1 comment 1 reply
-
No, it looks like a bug. I will release the fix at weekend. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://github.com/bucket4j/bucket4j/blob/master/bucket4j-core/src/main/java/io/github/bucket4j/distributed/proxy/optimization/manual/ManuallySyncingCommandExecutor.java#L121
Because of this line, in case of a short-term error by redis or another command executor, next command won't be executed successfully due to the preservation of CompletableFuture.fail
This behavior was intended as such?
Beta Was this translation helpful? Give feedback.
All reactions