-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ngrok v3 (potentially breaking change) #271
Comments
@philnash or other kind volunteers, can someone take a look please |
I'll take a look this weekend. Doesn't seem too much of a problem. |
Any updates on this? I recently got stuck with this problem, as I had installed ngrok 3 globally and authenticated with it, but when trying to connect with this library, it will always show I'm not authenticated. Turned out it is because ngrok2.4.0 used by this library looks for the |
Apologies, I've been busy with work and travelling recently. There is a pull request open to fix some of the ngrok 3 things but I don't know whether it helps to handle that at all. Would you be able to try installing from that branch and see if it helps? |
As I've mentioned in #272, ngrok 3 has a different download URL to ngrok 2. This means that upgrading to ngrok 3 for this package should be a major version change which changes the URLs in download.js and also handles the new commands and new location of config files for ngrok 3. |
Thanks for all your work here. It looks like the PR was merged so this can be closed? |
The PR is merged, there's a beta version out on npm now ( But check out the beta! |
From ngrok PM:
The text was updated successfully, but these errors were encountered: