Potluck flavours should clean /var/cache/pkg and /var/db/freebsd-update

[grembo]

I noticed after building a potluck flavour (in this example mariadb), that it keeps packages in /var/cache/pkg after installation. It also keeps /var/db/freebsd-update, in case the pot fbsd-update flavour was run.

This means images are bigger than required.

Example from mariadb on 14.1-RELEASE:

# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   619M  5.54G     1.49G  /opt/pot/jails/mariadb/m    
# rm -rf /opt/pot/jails/mariadb/m/var/cache/pkg/*
# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   476M  5.68G     1.34G  /opt/pot/jails/mariadb/m

freebsd-update is a bit more complicated, as in my example I inherited it from freebsd-potluck:

# rm -rf /opt/pot/jails/mariadb/m/var/db/freebsd-update
# zfs list zroot/pot/jails/mariadb/m
NAME                        USED  AVAIL     REFER  MOUNTPOINT
zroot/pot/jails/mariadb/m   476M  5.68G     1.01G  /opt/pot/jails/mariadb/m

As you can see, even though the usage won't go down, REFER went down by over 300MB (so the freebsd base image would shrink by that amount).

[grembo]

Example:

--- freebsd-potluck.sh.orig	2024-09-18 09:44:51.529801000 +0000
+++ freebsd-potluck.sh	2024-09-18 09:45:20.486070000 +0000
@@ -84,6 +84,10 @@
 service sshd onestop || true
 service sshd onedisable || true
 
+step "Clean freebsd-update"
+rm -rf /var/db/freebsd-update
+mkdir -p /var/db/freebsd-update
+
 step "Create /usr/local/etc/rc.d"
 mkdir -p /usr/local/etc/rc.d
 
@@ -115,7 +119,7 @@
 pkg install -y rsync
 
 step "Clean package installation"
-pkg clean -y
+pkg clean -ay
 
 # -------------- END PACKAGE SETUP -------------

and

--- mariadb.sh.orig	2024-09-18 09:46:08.726728000 +0000
+++ mariadb.sh	2024-09-18 09:46:28.730563000 +0000
@@ -83,6 +83,10 @@
 step "Create /usr/local/etc/rc.d"
 mkdir -p /usr/local/etc/rc.d
 
+step "Clean freebsd-update"
+rm -rf /var/db/freebsd-update
+mkdir -p /var/db/freebsd-update
+
 # we need consul for consul agent
 step "Install package consul"
 pkg install -y consul
@@ -131,7 +135,7 @@
 pkg install -y syslog-ng
 
 step "Clean package installation"
-pkg clean -y
+pkg clean -ay
 
 step "Create mysql directory"
 mkdir -p /var/db/mysql