Skip to content

Commit 7dfd3d6

Browse files
committed
feat: change log format
1 parent 79a101d commit 7dfd3d6

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

.codacy.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ engines:
33
golint:
44
govet:
55
coverage:
6-
#exclude_paths:
7-
# - config/engines.yml
86
exclude_paths:
97
- 'vendor/**'
108
- 'testdata/**/*'
9+
- 'README.md'

logger.go

+10-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package echozap
22

33
import (
4+
"fmt"
45
"time"
56

67
"github.com/labstack/echo/v4"
@@ -22,20 +23,20 @@ func ZapLogger(log *zap.Logger) echo.MiddlewareFunc {
2223
req := c.Request()
2324
res := c.Response()
2425

25-
id := req.Header.Get(echo.HeaderXRequestID)
26-
if id == "" {
27-
id = res.Header().Get(echo.HeaderXRequestID)
28-
}
29-
3026
fields := []zapcore.Field{
3127
zap.String("remote_ip", c.RealIP()),
3228
zap.String("time", time.Since(start).String()),
33-
zap.String("request_id", id),
3429
zap.String("host", req.Host),
35-
zap.String("method", req.Method),
36-
zap.String("uri", req.RequestURI),
30+
zap.String("request", fmt.Sprintf("%s %s", req.Method, req.RequestURI)),
3731
zap.Int("status", res.Status),
38-
zap.String("size", res.Header().Get("Content-Length")),
32+
zap.Int64("size", res.Size),
33+
zap.String("user_agent", req.UserAgent()),
34+
}
35+
36+
id := req.Header.Get(echo.HeaderXRequestID)
37+
if id == "" {
38+
id = res.Header().Get(echo.HeaderXRequestID)
39+
fields = append(fields, zap.String("request_id", id))
3940
}
4041

4142
n := res.Status

logger_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ func TestZapLogger(t *testing.T) {
3434
assert.Equal(t, 1, logs.Len())
3535
assert.Equal(t, int64(200), logFields["status"])
3636
assert.NotNil(t, logFields["time"])
37-
assert.Equal(t, "GET", logFields["method"])
38-
assert.Equal(t, "/something", logFields["uri"])
37+
assert.Equal(t, "GET /something", logFields["request"])
3938
assert.NotNil(t, logFields["host"])
4039
assert.NotNil(t, logFields["size"])
4140
}

0 commit comments

Comments
 (0)