Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: git commit new & changed passwords #347

Open
tennox opened this issue Apr 9, 2024 · 2 comments · May be fixed by browserpass/browserpass-native#147
Open

Feature request: git commit new & changed passwords #347

tennox opened this issue Apr 9, 2024 · 2 comments · May be fixed by browserpass/browserpass-native#147

Comments

@tennox
Copy link

tennox commented Apr 9, 2024

General information

  • Operating system + version: NixOS, linux 6.1

  • Browser + version: Firefox 123

  • Information about the host app:

    • How did you install it?
      NixOS: programs.browserpass.enable = true;
    • If installed an official release, put a version ($ browserpass --version): 3.1.0

  • Information about the browser extension:

    • How did you install it? pkgs.firefox.override { enableBrowserpass = true; }
    • Browserpass extension version as reported by your browser: 3.8.0

  • Using gopass 1.15.11 with an alias to pass

Exact steps to reproduce the problem

  1. Create password via extension UI
  2. Save
  3. Check git status in ~/.password-store

What should happen?

Created file should be committed

What happened instead?

untracked file, no commit
@gotjoshua
Copy link

same with chromium - no commit nor push

@maximbaz
Copy link
Member

Thanks for the feature request! Although browserpass is not using pass under the hood (the only dependency today is gpg), we do like to be compatible with it - pass doesn't do git pushes, but it does indeed do git commits, so we should consider this as well. I'll transfer this to the extension repo for more visibility, since if we were to do it, it's likely going to involve extension changes as well (e.g. to configure location of git binary).

@maximbaz maximbaz transferred this issue from browserpass/browserpass-native Apr 10, 2024
@maximbaz maximbaz changed the title Created passwords are not added to git Feature request: git commit new & changed passwords Apr 10, 2024
@tennox tennox linked a pull request Apr 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement git commit after save tennox/browserpass-native
3 participants
@maximbaz @tennox @gotjoshua