change how timestamp in created

Author: lucymcnatt

database/migration/src/main/resources/changesets/add_timestamp_in_call_caching.xml

@@ -6,7 +6,7 @@
 
     <changeSet id="add_timestamp_in_call_caching" author="lmcnatt" dbms="mysql,hsqldb,mariadb,postgresql">
         <addColumn tableName="CALL_CACHING_ENTRY">
-            <column name="CREATED_AT" type="TIMESTAMP" defaultValueComputed="CURRENT_TIMESTAMP">
+            <column name="CREATED_AT" type="TIMESTAMP">
                 <constraints nullable="false" />
             </column>
         </addColumn>

database/sql/src/main/scala/cromwell/database/sql/tables/CallCachingEntry.scala

@@ -1,7 +1,6 @@
 package cromwell.database.sql.tables
 
 import java.sql.Timestamp
-import java.time.Instant
 
 case class CallCachingEntry(
   workflowExecutionUuid: String,
@@ -11,6 +10,5 @@ case class CallCachingEntry(
   returnCode: Option[Int],
   allowResultReuse: Boolean,
   callCachingEntryId: Option[Long] = None,
-  // timestamp is set to time of CallCachingEntry creation by default
-  createdAt: Timestamp = Timestamp.from(Instant.now())
+  createdAt: Timestamp
 )

engine/src/main/scala/cromwell/engine/workflow/lifecycle/execution/callcaching/CallCache.scala

@@ -19,6 +19,8 @@ import cromwell.engine.workflow.lifecycle.execution.callcaching.EngineJobHashing
 import cromwell.services.CallCaching.CallCachingEntryId
 import wom.core._
 
+import java.sql.Timestamp
+import java.time.Instant
 import scala.concurrent.{ExecutionContext, Future}
 
 /**
@@ -33,7 +35,8 @@ class CallCache(database: CallCachingSqlDatabase) {
         jobIndex = b.jobIndex.fromIndex,
         jobAttempt = b.jobAttempt,
         returnCode = b.returnCode,
-        allowResultReuse = b.allowResultReuse
+        allowResultReuse = b.allowResultReuse,
+        createdAt = Timestamp.from(Instant.now())
       )
       val result = b.callOutputs.outputs.simplify
       val jobDetritus = b.jobDetritusFiles.getOrElse(Map.empty)

engine/src/test/scala/cromwell/engine/workflow/lifecycle/execution/callcaching/CallCachingSlickDatabaseSpec.scala

@@ -15,6 +15,8 @@ import org.scalatest.matchers.should.Matchers
 import org.scalatest.prop.TableDrivenPropertyChecks
 import org.scalatest.time.{Millis, Seconds, Span}
 
+import java.sql.Timestamp
+import java.time.Instant
 import scala.concurrent.ExecutionContext
 
 class CallCachingSlickDatabaseSpec
@@ -58,7 +60,8 @@ class CallCachingSlickDatabaseSpec
         1,
         None,
         None,
-        allowResultReuse = false
+        allowResultReuse = false,
+        createdAt = Timestamp.from(Instant.now())
       )
 
       val callCachingHashEntriesA = Seq(

server/src/test/scala/cromwell/engine/workflow/lifecycle/execution/ejea/EjeaCheckingCacheEntryExistenceSpec.scala

@@ -9,6 +9,8 @@ import cromwell.engine.workflow.tokens.JobTokenDispenserActor.JobTokenRequest
 import cromwell.jobstore.JobStoreActor.RegisterJobCompleted
 import cromwell.services.metadata.MetadataService.PutMetadataAction
 
+import java.sql.Timestamp
+import java.time.Instant
 import scala.util.control.NoStackTrace
 
 class EjeaCheckingCacheEntryExistenceSpec extends EngineJobExecutionActorSpec {
@@ -20,7 +22,14 @@ class EjeaCheckingCacheEntryExistenceSpec extends EngineJobExecutionActorSpec {
       createCheckingCacheEntryExistenceEjea()
 
       ejea ! CallCachingJoin(
-        CallCachingEntry(helper.workflowId.toString, helper.jobFqn, 0, None, None, allowResultReuse = true),
+        CallCachingEntry(helper.workflowId.toString,
+                         helper.jobFqn,
+                         0,
+                         None,
+                         None,
+                         allowResultReuse = true,
+                         createdAt = Timestamp.from(Instant.now())
+        ),
         List(CallCachingHashEntry("runtime attribute: docker", "HASHVALUE")),
         None,
         List.empty,

supportedBackends/google/batch/src/test/scala/cromwell/backend/google/batch/callcaching/BatchBackendCacheHitCopyingActorSpec.scala

@@ -54,6 +54,8 @@ class BatchBackendCacheHitCopyingActorSpec
 
   it should "do all the right things with blacklisting hits and buckets with groupings enabled" in {
 
+    // LM TODO add testing for max-result-age-days
+
     val configString =
       """
         |call-caching {