Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEGA-178-image-quantification #58

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

DEGA-178-image-quantification #58

wants to merge 15 commits into from

Conversation

jaspreetishar
Copy link
Contributor

No description provided.

@jaspreetishar jaspreetishar marked this pull request as ready for review February 5, 2025 16:14
@huanlity
Copy link
Contributor

@jaspreetishar Thanks for sending me the notebook and data for testing. They work fine on my end, except that I need to pip install rasterio on my end. I commented above to include it in the toml file.

After reviewing the script and the notebook, my biggest question for you is: what are you quantifying on the imagery data? The name of the ticket and and files suggested that but I am only seeing cell-level zonal stats calculation and filtering of cells based on manually inputted threshold. It is more like a interactive tool for positive calling? am I wrong about this? Thanks!

@huanlity
Copy link
Contributor

@jaspreetishar thanks for the quick response and changes, please see my comments above. Everything else looks good to me.

@huanlity
Copy link
Contributor

LGTM! ✅

@cornhundred
Copy link
Collaborator

looks good @jaspreetishar, let me just have a look over and then we can merge if you are not making any more changes

@jaspreetishar
Copy link
Contributor Author

I have added the last of the requested changes. Please go ahead with the review/ merge

cornhundred
cornhundred requested changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@cornhundred cornhundred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts, can you add an example notebook? Then we can we work to visualizing the results in the Landscape view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanlity huanlity huanlity left review comments

@cornhundred cornhundred cornhundred requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaspreetishar @huanlity @cornhundred