Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Brisk.Layout to Brisk.Style and remove the Layout functor #98

Open
wokalski opened this issue Mar 29, 2019 · 0 comments
Open

Move Brisk.Layout to Brisk.Style and remove the Layout functor #98

wokalski opened this issue Mar 29, 2019 · 0 comments
Labels
good first issue Good for newcomers macOS macOS renderer

Comments

@wokalski
Copy link
Member

Those changes will make our lives much much simpler.

  1. Remove this:
    https://github.com/briskml/brisk/blob/master/core/lib/Layout.re#L1

  2. Move core/lib/Layout.re to renderer-macos/lib/Styles.re

  3. Remove core
@wokalski wokalski added good first issue Good for newcomers macOS macOS renderer labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers macOS macOS renderer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wokalski