Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configureInstance stage on the native components #77

Open
rauanmayemir opened this issue Mar 7, 2019 · 0 comments
Open

Improve configureInstance stage on the native components #77

rauanmayemir opened this issue Mar 7, 2019 · 0 comments

Comments

@rauanmayemir
Copy link
Member

On our native components, most of the time configureInstance function consists of repetitive code that just sets style on the underlying host element.

We should think of a way to streamline it to be both less boilerplate-y and adjustable at the same time. By adjustable I mean that some of the style attributes could be set differently, but we could hide it under protocols on Obj-C side, I guess. For instance, while on <view> padding is solved by positioning children, on <text> it's set directly on the host element.

As for less boilerplate'y, there also has to be a way to memoize the attribute values as to avoid setting them on every change.

@rauanmayemir rauanmayemir mentioned this issue Mar 7, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant