Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HN app: Replace p tags in comment body by newline characters #111

Open
rauanmayemir opened this issue Apr 2, 2019 · 0 comments
Open

HN app: Replace p tags in comment body by newline characters #111

rauanmayemir opened this issue Apr 2, 2019 · 0 comments
Labels
good first issue Good for newcomers Hacker News App help wanted Extra attention is needed
Projects

Comments

@rauanmayemir
Copy link
Member

As marked in https://github.com/briskml/brisk/blob/master/examples/hacker-news/app/Story.re#L82, we'll need to transform incoming html.

<p> tags are not rendered with proper margin/padding by Cocoa in NSTextView by default, and instead of manually changing document attributes on ObjC bindings side, simply pre-processing html text and replacing paragraphs by newline characters seems more preferable.

We already use markup.ml, so it shouldn't be hard to do the adjustments. The relevant part to look at is http://aantron.github.io/markup.ml/#VALtree

@rauanmayemir rauanmayemir created this issue from a note in HN app (Backlog) Apr 2, 2019
@rauanmayemir rauanmayemir added help wanted Extra attention is needed good first issue Good for newcomers Hacker News App labels Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacker News App help wanted Extra attention is needed
Projects
HN app
  
Backlog
Development

No branches or pull requests

1 participant