We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
You might check PEP8. flake8 can help
flake8
$ flake8 cbor cbor/cbor.py:24:10: E221 multiple spaces before operator cbor/cbor.py:25:12: E221 multiple spaces before operator cbor/cbor.py:26:11: E221 multiple spaces before operator cbor/cbor.py:27:10: E221 multiple spaces before operator cbor/cbor.py:28:11: E221 multiple spaces before operator cbor/cbor.py:29:9: E221 multiple spaces before operator cbor/cbor.py:30:9: E221 multiple spaces before operator cbor/cbor.py:31:7: E221 multiple spaces before operator cbor/cbor.py:33:19: E221 multiple spaces before operator cbor/cbor.py:37:17: E221 multiple spaces before operator cbor/cbor.py:39:11: E221 multiple spaces before operator cbor/cbor.py:41:11: E221 multiple spaces before operator cbor/cbor.py:42:10: E221 multiple spaces before operator cbor/cbor.py:43:10: E221 multiple spaces before operator cbor/cbor.py:44:15: E221 multiple spaces before operator cbor/cbor.py:50:25: E261 at least two spaces before inline comment cbor/cbor.py:51:24: E261 at least two spaces before inline comment cbor/cbor.py:51:80: E501 line too long (88 > 79 characters) cbor/cbor.py:52:20: E261 at least two spaces before inline comment cbor/cbor.py:53:23: E261 at least two spaces before inline comment cbor/cbor.py:54:21: E261 at least two spaces before inline comment cbor/cbor.py:55:22: E261 at least two spaces before inline comment cbor/cbor.py:59:19: E261 at least two spaces before inline comment cbor/cbor.py:65:19: E261 at least two spaces before inline comment cbor/cbor.py:65:80: E501 line too long (80 > 79 characters) cbor/cbor.py:66:33: E261 at least two spaces before inline comment cbor/cbor.py:86:80: E501 line too long (86 > 79 characters) cbor/cbor.py:115:80: E501 line too long (103 > 79 characters) cbor/cbor.py:126:9: E129 visually indented line with same indent as next logical line cbor/cbor.py:129:80: E501 line too long (84 > 79 characters) cbor/cbor.py:131:80: E501 line too long (85 > 79 characters) cbor/cbor.py:139:32: F821 undefined name 'unicode' cbor/cbor.py:147:35: E712 comparison to True should be 'if cond is True:' or 'if cond:' cbor/cbor.py:168:18: E231 missing whitespace after ',' cbor/cbor.py:182:18: E231 missing whitespace after ',' cbor/cbor.py:195:80: E501 line too long (82 > 79 characters) cbor/cbor.py:196:1: W293 blank line contains whitespace cbor/cbor.py:201:5: E301 expected 1 blank line, found 0 cbor/cbor.py:205:36: F821 undefined name 'basestring' cbor/cbor.py:205:55: F821 undefined name 'unicode' cbor/cbor.py:206:5: E301 expected 1 blank line, found 0 cbor/cbor.py:207:36: F821 undefined name 'long' cbor/cbor.py:228:80: E501 line too long (83 > 79 characters) cbor/cbor.py:346:5: E301 expected 1 blank line, found 0 cbor/cbor.py:358:18: F821 undefined name 'xrange' cbor/cbor.py:363:5: E301 expected 1 blank line, found 0 cbor/cbor.py:365:18: F821 undefined name 'xrange' cbor/cbor.py:372:1: W293 blank line contains whitespace cbor/cbor.py:383:1: E302 expected 2 blank lines, found 1 cbor/cbor.py:384:80: E501 line too long (83 > 79 characters) cbor/cbor.py:471:80: E501 line too long (81 > 79 characters) cbor/cbor.py:508:80: E501 line too long (108 > 79 characters) cbor/cbor_rpc_client.py:3:1: F401 'random' imported but unused cbor/cbor_rpc_client.py:61:80: E501 line too long (173 > 79 characters) cbor/cbor_rpc_client.py:142:57: E231 missing whitespace after ',' cbor/cbor_rpc_client.py:165:9: E231 missing whitespace after ',' cbor/cbor_rpc_client.py:169:38: E231 missing whitespace after ':' cbor/cbor_rpc_client.py:169:44: E231 missing whitespace after ',' cbor/cbor_rpc_client.py:171:38: E231 missing whitespace after ',' cbor/cbor_rpc_client.py:171:51: E231 missing whitespace after ',' cbor/cbor_rpc_client.py:172:5: E265 block comment should start with '# ' cbor/cbor_rpc_client.py:173:5: E265 block comment should start with '# ' cbor/cbor_rpc_client.py:175:1: W391 blank line at end of file cbor/cbor_rpc_client.py:175:1: W293 blank line contains whitespace cbor/tagmap.py:15:80: E501 line too long (87 > 79 characters) cbor/tagmap.py:16:80: E501 line too long (120 > 79 characters) cbor/tagmap.py:18:80: E501 line too long (81 > 79 characters) cbor/tagmap.py:34:80: E501 line too long (80 > 79 characters) cbor/tagmap.py:55:13: E265 block comment should start with '# ' cbor/tagmap.py:61:18: E231 missing whitespace after ',' cbor/tagmap.py:79:18: E231 missing whitespace after ',' cbor/tagmap.py:88:18: E231 missing whitespace after ',' cbor/tests/test_cbor.py:18:1: E402 module level import not at top of file cbor/tests/test_cbor.py:19:1: E402 module level import not at top of file cbor/tests/test_cbor.py:20:1: E402 module level import not at top of file cbor/tests/test_cbor.py:21:1: E402 module level import not at top of file cbor/tests/test_cbor.py:22:1: E402 module level import not at top of file cbor/tests/test_cbor.py:41:14: F821 undefined name 'xrange' cbor/tests/test_cbor.py:49:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:52:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:55:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:58:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:61:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:63:80: E501 line too long (124 > 79 characters) cbor/tests/test_cbor.py:70:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:73:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:76:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:79:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:86:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:91:5: E301 expected 1 blank line, found 0 cbor/tests/test_cbor.py:100:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:102:80: E501 line too long (124 > 79 characters) cbor/tests/test_cbor.py:115:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:117:80: E501 line too long (124 > 79 characters) cbor/tests/test_cbor.py:137:11: E231 missing whitespace after ',' cbor/tests/test_cbor.py:137:13: E231 missing whitespace after ',' cbor/tests/test_cbor.py:147:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:152:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:161:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:173:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:180:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:181:15: E231 missing whitespace after ',' cbor/tests/test_cbor.py:181:17: E231 missing whitespace after ',' cbor/tests/test_cbor.py:188:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:189:80: E501 line too long (127 > 79 characters) cbor/tests/test_cbor.py:202:80: E501 line too long (190 > 79 characters) cbor/tests/test_cbor.py:203:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:204:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:205:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:206:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:207:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:208:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:209:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:210:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:211:13: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:214:80: E501 line too long (88 > 79 characters) cbor/tests/test_cbor.py:218:9: F841 local variable 'bo2' is assigned to but never used cbor/tests/test_cbor.py:221:9: F841 local variable 'jo2' is assigned to but never used cbor/tests/test_cbor.py:224:80: E501 line too long (168 > 79 characters) cbor/tests/test_cbor.py:235:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:237:13: F841 local variable 'ob' is assigned to but never used cbor/tests/test_cbor.py:243:80: E501 line too long (80 > 79 characters) cbor/tests/test_cbor.py:244:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:261:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:263:13: F841 local variable 'ob' is assigned to but never used cbor/tests/test_cbor.py:266:13: E265 block comment should start with '# ' cbor/tests/test_cbor.py:273:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:276:9: F841 local variable 'xb' is assigned to but never used cbor/tests/test_cbor.py:276:54: E231 missing whitespace after ',' cbor/tests/test_cbor.py:276:56: E231 missing whitespace after ',' cbor/tests/test_cbor.py:276:59: E231 missing whitespace after ',' cbor/tests/test_cbor.py:276:62: E231 missing whitespace after ',' cbor/tests/test_cbor.py:276:65: E231 missing whitespace after ',' cbor/tests/test_cbor.py:276:80: E501 line too long (82 > 79 characters) cbor/tests/test_cbor.py:279:31: E701 multiple statements on one line (colon) cbor/tests/test_cbor.py:283:38: E231 missing whitespace after ':' cbor/tests/test_cbor.py:290:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:300:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:301:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:302:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:303:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:304:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:305:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:306:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:307:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:308:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:309:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:309:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:310:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:310:80: E501 line too long (88 > 79 characters) cbor/tests/test_cbor.py:311:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:311:80: E501 line too long (95 > 79 characters) cbor/tests/test_cbor.py:312:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:312:80: E501 line too long (100 > 79 characters) cbor/tests/test_cbor.py:313:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:313:80: E501 line too long (107 > 79 characters) cbor/tests/test_cbor.py:314:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:314:80: E501 line too long (114 > 79 characters) cbor/tests/test_cbor.py:315:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:315:80: E501 line too long (121 > 79 characters) cbor/tests/test_cbor.py:316:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:316:80: E501 line too long (128 > 79 characters) cbor/tests/test_cbor.py:317:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:317:80: E501 line too long (135 > 79 characters) cbor/tests/test_cbor.py:318:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:318:80: E501 line too long (142 > 79 characters) cbor/tests/test_cbor.py:319:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:319:80: E501 line too long (149 > 79 characters) cbor/tests/test_cbor.py:320:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:320:80: E501 line too long (156 > 79 characters) cbor/tests/test_cbor.py:321:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:321:80: E501 line too long (163 > 79 characters) cbor/tests/test_cbor.py:322:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:322:80: E501 line too long (174 > 79 characters) cbor/tests/test_cbor.py:323:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:323:80: E501 line too long (185 > 79 characters) cbor/tests/test_cbor.py:324:1: E122 continuation line missing indentation or outdented cbor/tests/test_cbor.py:324:80: E501 line too long (196 > 79 characters) cbor/tests/test_cbor.py:327:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:329:31: F821 undefined name 'cbor' cbor/tests/test_cbor.py:329:62: E231 missing whitespace after ':' cbor/tests/test_cbor.py:329:80: E501 line too long (110 > 79 characters) cbor/tests/test_cbor.py:331:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:333:31: F821 undefined name 'cbor' cbor/tests/test_cbor.py:333:62: E231 missing whitespace after ':' cbor/tests/test_cbor.py:333:80: E501 line too long (111 > 79 characters) cbor/tests/test_cbor.py:339:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:342:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:345:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:352:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:353:80: E501 line too long (87 > 79 characters) cbor/tests/test_cbor.py:355:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:356:54: E231 missing whitespace after ',' cbor/tests/test_cbor.py:358:1: E305 expected 2 blank lines after class or function definition, found 1 cbor/tests/test_cbor.py:360:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:361:75: E231 missing whitespace after ',' cbor/tests/test_cbor.py:361:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:362:24: E231 missing whitespace after ',' cbor/tests/test_cbor.py:373:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:374:75: E231 missing whitespace after ',' cbor/tests/test_cbor.py:374:80: E501 line too long (81 > 79 characters) cbor/tests/test_cbor.py:376:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:378:37: E231 missing whitespace after ',' cbor/tests/test_cbor.py:393:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:396:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:399:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:402:1: E305 expected 2 blank lines after class or function definition, found 1 cbor/tests/test_cbor.py:403:1: E302 expected 2 blank lines, found 0 cbor/tests/test_cbor.py:406:1: E305 expected 2 blank lines after class or function definition, found 1 cbor/tests/test_cbor.py:431:1: E302 expected 2 blank lines, found 1 cbor/tests/test_cbor.py:431:80: E501 line too long (84 > 79 characters) cbor/tests/test_objects.py:8:1: E265 block comment should start with '# ' cbor/tests/test_objects.py:9:1: F401 'cbor.tests.test_cbor.TestPyPy' imported but unused cbor/tests/test_objects.py:10:1: E265 block comment should start with '# ' cbor/tests/test_objects.py:31:80: E501 line too long (82 > 79 characters) cbor/tests/test_objects.py:51:80: E501 line too long (81 > 79 characters) cbor/tests/test_objects.py:53:80: E501 line too long (124 > 79 characters) cbor/tests/test_objects.py:57:29: E231 missing whitespace after ',' cbor/tests/test_objects.py:78:9: F841 local variable 'ok' is assigned to but never used cbor/tests/test_objects.py:82:3: E111 indentation is not a multiple of four cbor/tests/test_usage.py:30:1: E303 too many blank lines (3) cbor/tests/test_usage.py:41:14: F821 undefined name 'xrange' cbor/tests/test_usage.py:58:17: F841 local variable 'blob' is assigned to but never used cbor/tests/test_usage.py:59:80: E501 line too long (83 > 79 characters) cbor/tests/test_usage.py:65:80: E501 line too long (90 > 79 characters) cbor/tests/test_usage.py:66:80: E501 line too long (86 > 79 characters) cbor/tests/test_usage.py:68:80: E501 line too long (141 > 79 characters) cbor/tests/test_usage.py:69:80: E501 line too long (136 > 79 characters) cbor/tests/test_usage.py:81:9: E266 too many leading '#' for block comment cbor/tests/test_usage.py:82:9: E265 block comment should start with '# ' cbor/tests/test_usage.py:83:9: E266 too many leading '#' for block comment cbor/tests/test_usage.py:84:9: E265 block comment should start with '# ' cbor/tests/test_usage.py:85:9: E266 too many leading '#' for block comment cbor/tests/test_usage.py:86:9: E265 block comment should start with '# ' cbor/tests/test_usage.py:88:9: E265 block comment should start with '# ' cbor/tests/test_usage.py:89:21: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:24: E231 missing whitespace after ',' cbor/tests/test_usage.py:89:26: E231 missing whitespace after ',' cbor/tests/test_usage.py:89:28: E231 missing whitespace after ',' cbor/tests/test_usage.py:89:31: E231 missing whitespace after ',' cbor/tests/test_usage.py:89:37: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:43: E231 missing whitespace after ',' cbor/tests/test_usage.py:89:51: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:58: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:70: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:80: E501 line too long (131 > 79 characters) cbor/tests/test_usage.py:89:94: E231 missing whitespace after ':' cbor/tests/test_usage.py:89:103: E231 missing whitespace after ':' cbor/tests/test_usage.py:95:17: F841 local variable 'dob' is assigned to but never used cbor/tests/test_usage.py:96:80: E501 line too long (83 > 79 characters) cbor/tests/test_usage.py:102:80: E501 line too long (90 > 79 characters) cbor/tests/test_usage.py:103:80: E501 line too long (86 > 79 characters) cbor/tests/test_usage.py:105:80: E501 line too long (141 > 79 characters) cbor/tests/test_usage.py:106:80: E501 line too long (136 > 79 characters) cbor/tests/test_usage.py:133:80: E501 line too long (98 > 79 characters) cbor/tests/test_usage.py:134:80: E501 line too long (94 > 79 characters) cbor/tests/test_usage.py:136:80: E501 line too long (149 > 79 characters) cbor/tests/test_usage.py:137:80: E501 line too long (144 > 79 characters) cbor/tests/test_usage.py:139:80: E501 line too long (80 > 79 characters) cbor/tests/test_usage.py:142:80: E501 line too long (94 > 79 characters) cbor/tests/test_usage.py:151:25: F841 local variable 'dob' is assigned to but never used cbor/tests/test_usage.py:152:80: E501 line too long (91 > 79 characters) cbor/tests/test_usage.py:159:80: E501 line too long (98 > 79 characters) cbor/tests/test_usage.py:160:80: E501 line too long (94 > 79 characters) cbor/tests/test_usage.py:162:80: E501 line too long (149 > 79 characters) cbor/tests/test_usage.py:163:80: E501 line too long (144 > 79 characters) cbor/tests/test_usage.py:165:80: E501 line too long (80 > 79 characters) cbor/tests/test_usage.py:202:80: E501 line too long (90 > 79 characters) cbor/tests/test_usage.py:203:80: E501 line too long (86 > 79 characters) cbor/tests/test_usage.py:205:80: E501 line too long (141 > 79 characters) cbor/tests/test_usage.py:206:80: E501 line too long (136 > 79 characters) cbor/tests/test_usage.py:220:17: F841 local variable 'dob' is assigned to but never used cbor/tests/test_usage.py:221:80: E501 line too long (83 > 79 characters) cbor/tests/test_usage.py:228:80: E501 line too long (90 > 79 characters) cbor/tests/test_usage.py:229:80: E501 line too long (86 > 79 characters) cbor/tests/test_usage.py:231:80: E501 line too long (141 > 79 characters) cbor/tests/test_usage.py:232:80: E501 line too long (136 > 79 characters) cbor/tests/test_usage.py:239:1: E303 too many blank lines (3) cbor/tests/test_vectors.py:23:1: E265 block comment should start with '# ' cbor/tests/test_vectors.py:24:1: E402 module level import not at top of file cbor/tests/test_vectors.py:26:5: E265 block comment should start with '# ' cbor/tests/test_vectors.py:31:5: E265 block comment should start with '# ' cbor/tests/test_vectors.py:33:1: E402 module level import not at top of file cbor/tests/test_vectors.py:44:80: E501 line too long (119 > 79 characters) cbor/tests/test_vectors.py:53:80: E501 line too long (91 > 79 characters) cbor/tests/test_vectors.py:64:80: E501 line too long (132 > 79 characters) cbor/tests/test_vectors.py:68:9: F841 local variable 'anyerr' is assigned to but never used cbor/tests/test_vectors.py:69:80: E501 line too long (129 > 79 characters) cbor/tests/test_vectors.py:78:80: E501 line too long (132 > 79 characters) cbor/tests/test_vectors.py:78:94: F821 undefined name 'decoded' cbor/tests/test_vectors.py:82:9: F841 local variable 'anyerr' is assigned to but never used cbor/tests/test_vectors.py:83:80: E501 line too long (129 > 79 characters) cbor/tests/test_vectors.py:83:91: F821 undefined name 'decoded' cbor/tests/test_vectors.py:89:80: E501 line too long (93 > 79 characters) cbor/tests/test_vectors.py:91:80: E501 line too long (90 > 79 characters) cbor/tests/test_vectors.py:122:80: E501 line too long (117 > 79 characters) cbor/tests/test_vectors.py:132:80: E501 line too long (120 > 79 characters) cbor/tests/test_vectors.py:134:80: E501 line too long (106 > 79 characters)
This could also be add to continuous integration.
Kind regards
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello,
You might check PEP8.
flake8
can helpThis could also be add to continuous integration.
Kind regards
The text was updated successfully, but these errors were encountered: