Skip to content

Do not serialize new Date(undefined) as "0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN" #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikonst opened this issue Sep 20, 2024 · 2 comments
Labels

Comments

@ikonst
Copy link

ikonst commented Sep 20, 2024

Currently new Date(undefined) (an invalid date) is serialized as "0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN" which is not parsed by Postgres in any meaningful way.

We can either fail early by throwing a JS error, or produce a Postgres value that more obviously indicates an invalid date (e.g. "Invalid date").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants