-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion won't be formatted correctly in _arguments #28
Comments
Aha thanks! Partially addressed this by fixing the broken f-string, so the assertion error should be useful now. Need to think about whether this should be converted to an exception. *I understand this isn't the case if you're dynamically reading defaults from a YAML. But I'm not sure it's tyro's responsibility if you have a field annotated as import tyro
def main(x: bool = "False") -> None:
pass
tyro.cli(main) # Should trigger the same error. |
Sorry for the issue spamming- but here's a small bug report that this assertion needs to be replaced by an Exception to properly display which fields have issues in the defaults. I would submit a PR but I'll probably get the type of Exception to use wrong :D
tyro/tyro/_arguments.py
Lines 198 to 201 in e88e690
The text was updated successfully, but these errors were encountered: