Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to single pass compiler #197

Open
breck7 opened this issue Feb 17, 2025 · 0 comments
Open

Switch to single pass compiler #197

breck7 opened this issue Feb 17, 2025 · 0 comments

Comments

@breck7
Copy link
Owner

breck7 commented Feb 17, 2025

The original implementation is a 2 pass compiler. The first pass parsers all of the Parsers, compiles them to one combined parser, and the 2nd pass parses the Scroll document.

At this point I believe a better design is a single pass that incrementally builds up the Parser Pool as we go.

Benefits:

  • Simpler conceptual model
  • Simpler code to maintain (once it works)
  • Allows for new capabilities, like overriding parsers in the middle of a program (can be helpful when you are merging multiple scrollsets into one file)
  • More straightforward code should allow for perf improvements

The main driver is the slow performance of large ScrollSets, and wanting to radically improve that, but having to currently deal with the convoluted Fusion code.

But it is a significant challenge to switch to that new design, given the current implementation.

Still in the investigative phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant