Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Consider adding ascii diagram/charts/arts in the example snippet #176

Open
sam-rad opened this issue Feb 8, 2025 · 2 comments
Open

Comments

@sam-rad
Copy link

sam-rad commented Feb 8, 2025

It would be very helpful to pick if the default snippet also includes some ascii diagram/charts as comment. There are a few fonts that don't handle those pretty:

Good Example:

Image

Bad Example:

Image

And here's the comments I used:

      ╭─────────────────────────────╮
      │                  ╭───╮      │
      │  ╭───╮           │╭─╮│      │
      │  ↑   │           │↑ ││      │
void (*signal(int, void (*fp)(int)))(int);
 ↑    ↑      │      ↑    ↑  ││      │
 │    ╰──────╯      │    ╰──╯│      │
 │                  ╰────────╯      │
 ╰──────────────────────────────────╯
 
 
okta-awscli --okta-profile=aws-666 --profile=aws-666
            ╰────────┬───────────╯ ╰───────┬──────╯
                     │                     │
                     │	                   ╰────── profile to store temporary credentials
                     ╰────── profile to use in .okta-aws

If this is something you're open to adding, I can prepare a diff myself.

@braver
Copy link
Owner

braver commented Feb 9, 2025

For sure, that would be super helpful. Perhaps try and find a compact example that covers as much as possible in as few lines as possible?

@braver
Copy link
Owner

braver commented Feb 19, 2025

Hey, I just added a code sample menu so code moved around a bit. You're still welcome to add ascii to an existing code sample, or perhaps add a separate ascii art sample?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants