Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR125] Tab search button icon is hidden when hovered/pressed #38182

Closed
simonhong opened this issue May 9, 2024 · 2 comments · Fixed by brave/brave-core#23527
Closed

[CR125] Tab search button icon is hidden when hovered/pressed #38182

simonhong opened this issue May 9, 2024 · 2 comments · Fixed by brave/brave-core#23527
Assignees
@simonhong
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop OS/Windows QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented May 9, 2024 •
edited

Description

Steps to Reproduce

  1. Hover/Press tab search button
  2. Enable vertical tab mode and check search button

Actual result:

Image is invisible when hovered/pressed
image
image

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @rebron @brave/qa-team
@simonhong simonhong self-assigned this May 9, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 9, 2024
@simonhong
Fixed tab search button's icon is invisible
6a3c3bb 
fix brave/brave-browser#38182
@simonhong simonhong mentioned this issue May 9, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 9, 2024
This was referenced May 10, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.66.105 or higher for 1.66.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.66.105 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | ba88d7bb175a55287d14014823d5da31fe9c8a47
OS | Windows 10 Version 22H2 (Build 19045.4291)

Using the STR/Cases outlined via #38182 (comment), ensured that the Search button is being displayed when clicked as per the following:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop OS/Windows QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed tab search button's icon is invisible brave/brave-core
4 participants
@kjozwiak @simonhong @GeetaSarvadnya @brave-builds