Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed Microsoft Bing to Bing #23526

Merged
merged 1 commit into from May 9, 2024
Merged

Renamed Microsoft Bing to Bing #23526

merged 1 commit into from May 9, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 9, 2024 •
edited

fix brave/brave-browser#38179

AFAIK, android caches search provider's name in prefs.
So, if existing provider's name is changed, it could affect default search provider.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue.

@simonhong simonhong self-assigned this May 9, 2024
@simonhong simonhong marked this pull request as ready for review May 9, 2024 05:49
bsclifton
bsclifton approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Did not test it to see if it fixes the issue

AlexeyBarabash
AlexeyBarabash approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong simonhong merged commit cba1c5e into master May 9, 2024
20 checks passed
@simonhong simonhong deleted the rename_bing_search_provider_name branch May 9, 2024 23:01
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 9, 2024
brave-builds added a commit that referenced this pull request May 10, 2024
@brave-builds
Uplift of #23526 (squashed) to beta
20566ef
brave-builds added a commit that referenced this pull request May 10, 2024
@brave-builds
Uplift of #23526 (squashed) to release
215aa17
This was referenced May 10, 2024
Merged
Merged
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.11 Chromium: 125.0.6422.41 (Official Build) nightly (64-bit)
-- | --
Revision | 5cb22df110641de56c3f1149ca7b49b92a3f6415
OS | Windows 11 Version 23H2 (Build 22631.3527)

Even though the original issue has been reported/reproduced on Android, quickly went through the latest Nightly on Desktop and ensured that Microsoft Bing was renamed to Bing without any issues/obvious regressions:

  • ensured that selecting Bing for both Normal & Private windows didn't cause any issues
  • ensured that you can select all the other SE and the correct ones are being used when selected
  • ensured that restarting the browser retains the users SE selection (including Bing)
Example Example
desktop1 desktop2

@kjozwiak kjozwiak mentioned this pull request May 13, 2024
Closed
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.68.11 Chromium: 125.0.6422.41 (Build officiel) canary (64 bits)
--- | ---
Révision | 5cb22df110641de56c3f1149ca7b49b92a3f6415
Système d'exploitation | Android 14; Build/AP21.240305.005; 34; REL

Using the STR/Cases outlined via brave/brave-browser#38179 (comment), ensured that the correct SE were being selected. Also ensured that Microsoft Bing was renamed back to Bing which was changed in C125.

screen-20240513-141329.mp4

kjozwiak pushed a commit that referenced this pull request May 13, 2024
@brave-builds
Renamed Microsoft Bing to Bing (uplift to 1.67.x) (#23561)
58de105 
Uplift of #23526 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request May 13, 2024
@brave-builds
Renamed Microsoft Bing to Bing (uplift to 1.66.x) (#23562)
79afacd 
Uplift of #23526 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.68.x - Nightly
4 participants
@simonhong @kjozwiak @bsclifton @AlexeyBarabash