Fixed line/column number in violations.

Better NoQuotationMark detection.
brainsum · Jun 8, 2023 · aa7648f · aa7648f
1 parent 6f22a6a
commit aa7648f
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/brainsum_twigcs/src/Rule/NoQuotationMarkAttributeRule.php b/brainsum_twigcs/src/Rule/NoQuotationMarkAttributeRule.php
@@ -23,14 +23,17 @@ public function check(TokenStream $tokens)
  Token::VAR_START_TYPE === $tokens->look(Lexer::NEXT_TOKEN)->getType() &&
  Token::WHITESPACE_TYPE === $tokens->look(2)->getType() &&
  Token::NAME_TYPE === $tokens->look(3)->getType()) {
-
- $violations[] = $this->createViolation(
- $tokens->getSourceContext()->getPath(),
- $token->getLine(),
- $token->getColumn() + strlen($token->getValue()) + 1,
- 'Unsafe attribute value without quotation mark.'
- );
- }
+ $quots = substr_count(strstr($token->getValue(), '<'), '"');
+
+ if (!($quots % 2)) {
+ $violations[] = $this->createViolation(
+ $tokens->getSourceContext()->getPath(),
+ $tokens->look(Lexer::NEXT_TOKEN)->getLine(),
+ $tokens->look(Lexer::NEXT_TOKEN)->getColumn() + strlen($tokens->look(Lexer::NEXT_TOKEN)->getValue()) - 1,
+ 'Unsafe attribute value without quotation mark.'
+ );
+ }
+ }
 
  $tokens->next();
  }