Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support python3 #82

Open
RaghavRao opened this issue Jan 27, 2020 · 5 comments
Open

Upgrade to support python3 #82

RaghavRao opened this issue Jan 27, 2020 · 5 comments

Comments

@RaghavRao
Copy link

Python 2 has reached end of life in January 2020, causing venvburrito to fail on install

@mattrobenolt
Copy link
Collaborator

In what way does it fail? python2 didn’t just stop working in January.

@richamehta87
Copy link

It fails here:

curl -sL https://raw.githubusercontent.com/brainsik/virtualenv-burrito/master/virtualenv-burrito.sh | $SHELL
File "", line 1
import platform;print ".".join(platform.python_version().split(".")[:2])
^
SyntaxError: invalid syntax

@skytreader
Copy link

So what's the team's official stance on supporting Python3 exclusively? I think it makes sense to go this direction because:

  • The rationale of having virtualenv and virtualenvwrapper is to isolate Python environments and prevent messing with the system-utilized Python.
  • Python2 is no longer supported since start of this year. (So this tool is catering to an unsupported Python version by default.)
  • Anyone starting a new project should be choosing Python3 exclusively. (So any tool that caters to Python2 by default is useless for them.)
  • As it stands, the only things that has any business to do with Python2 are OS-level utilities/daemons like, say, those in Ubuntu 16.04 which is still a supported Ubuntu version but was released with a Python 2.7 interpreter. (But these things won't benefit from a tool like virtualenv so we can stand to abandon them).

Of course, it is very likely that a bunch of non-systems-level projects are still on Python2. But I guess the question is does this project want to support them? Can't they just, for instance, checkout a specific revision of virtualenv-burrito to support themselves? (To be clear, I have nothing against supporting legacy but I want to know this project's official stance on this so I can adjust myself accordingly; I heavily favor supporting Python3 exclusively.)

I know the mkvirtualenv -p exists so it's not like Python3 is not supported at all. However, the problem is that the latest version of pip is Python3-exclusive so now by default this project is, at least, one pip version behind. And actually this seems to conflict when creating a Python3 virtualenv. It seems that Python3, somehow, must use pip 20 which virtualenv-burrito can't serve (this is a problem I encountered personally and, caveat, I didn't really investigate why it happens but I managed to solve it by moving exclusively to Python3).

@skytreader
Copy link

FYI I have a working branch ready to PR if this project decides to support Python3 exclusively.

@mattrobenolt
Copy link
Collaborator

My POV here as someone who has long used this project and highly advocated and a maintainer, I don’t use it anymore with python3. The problems this project addressed don’t exist in the ecosystem anymore. Python3 has virtualenv built in and paired with pyenv has been a really solid setup. You’re free to use virtualenv and virtualenvwrapper directly these days, and the problems this project attempted to solve many years ago just aren’t a problem today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants