ORCID link leads to 404

[CodyCBakerPhD]

On the profile page

following the link goes to https://brain-bbqs.org/0000-0002-0829-4790 which is 404

whereas it is surely meant to redirect or embed https://orcid.org/0000-0002-0829-4790

[satra]

@claude Can you look at this issue and determine if the ORCID link logic is in the codebase? Just identify the relevant file(s) and report back.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[claude]

Claude finished @satra's task in 1m 52s —— View job

---

Tasks

• Gather context and understand request
• Read CLAUDE.md for repo guidelines (none found)
• Search for ORCID link logic in codebase
• Report findings

---

Findings

Yes, the ORCID link logic is in the codebase. The relevant file is:

src/components/entity-summary/summaries/InvestigatorSummary.tsx

There are actually two rendering paths for the ORCID link, and they're inconsistent — which is the root cause of the bug:

Path 1 — non-edit mode (correct) — lines 236–239:

<a href={`https://orcid.org/${data.orcid}`} target="_blank" rel="noopener noreferrer" ...>
  {data.orcid} <ExternalLink className="h-3 w-3" />
</a>

This correctly prepends https://orcid.org/ to the stored ORCID ID.

Path 2 — edit mode (broken) — via the EditableText component at line 235:

<EditableText value={data.orcid || ""} onSave={...} type="url" />

Inside EditableText (lines 31–33), when type="url", it renders:

<a href={value} ...>  // value = "0000-0002-0829-4790" (no base URL!)

Since value is just the bare ORCID ID (e.g. 0000-0002-0829-4790), the browser interprets href="0000-0002-0829-4790" as a relative path — resolving to https://brain-bbqs.org/0000-0002-0829-4790 → 404.

Why only some users see it: The edit mode (canEdit = true) is shown to investigators viewing their own profile. Those users get the broken EditableText link; other visitors get the correct non-edit link.

The fix would be in InvestigatorSummary.tsx — the EditableText display for ORCID should prepend https://orcid.org/ before using it as an href, similar to how the non-edit path does it.

[satra]

@claude - submit a PR for it.

[claude]

Claude finished @satra's task in 1m 53s —— View job • claude/issue-89-20260409-1911 • Create PR ➔

---

Tasks

• Gather context and understand request
• Read relevant files (InvestigatorSummary.tsx)
• Apply fix: add href prop to EditableText for ORCID and Google Scholar
• Commit and push changes
• Post PR link

Summary

Fixed in src/components/entity-summary/summaries/InvestigatorSummary.tsx:

Root cause: EditableText with type="url" was using href={value} where value is the bare ORCID ID (0000-0002-0829-4790). The browser resolves this as a relative path → https://brain-bbqs.org/0000-0002-0829-4790 → 404.

Fix: Added an optional href prop to EditableText (line 23). When provided, it overrides the link destination while the display text remains the bare ID. Updated both ORCID and Google Scholar usages to pass the correct full URLs:

• ORCID: https://orcid.org/<id>
• Google Scholar: https://scholar.google.com/citations?user=<id>

This matches the behavior of the non-edit code paths that were already correct.

·