Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #8

Open
bradleyfay opened this issue Jul 17, 2015 · 7 comments
Open

Testing #8

bradleyfay opened this issue Jul 17, 2015 · 7 comments

Comments

@bradleyfay
Copy link
Owner

Need to develop and integrate testing framework for the package.

@bpblanken
Copy link

Hey,

I'm interested in working on this, and potentially other enhancements down the line.

Any thoughts on what you want to use?

@bradleyfay
Copy link
Owner Author

Awesome.

To be honest, I have no idea. I was reading through a blog about open sourcing a package when I first started building and one of the features they talked about was automatic testing.

If you want to take ownership of that aspect and choose a direction, that would be great. You'll just have to teach me a bit about it along the way.

@2bitProgammer
Copy link

Are you talking about doing Travis-CI integration?

@bradleyfay
Copy link
Owner Author

That's what I had started but haven't taken time to learn how to do it correctly. Package works but just get failure messages from Travis.

Any help here would be thoroughly appreciated.

@bpblanken
Copy link

Yes. All that good stuff.

@bradleyfay
Copy link
Owner Author

With the new refactor, I'm taking advantage of classing to minimize duplicate code.

Once it's done I think it should be easier to write tests for each modules. Would be great to get some help on this once refactor is done.

Would actually like to consider a jenkins up to periodically test package and all the calls to identify if the NBA makes any other breaking changes to their stats website.

@bradleyfay
Copy link
Owner Author

@bpblanken Think I finally understand class inheritance in a way that makes building the modules with much less copy and paste. Hopefully it's a bit more straight forward to set up some simple testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants