Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 #22

Open
danielmcintosh1 opened this issue Mar 7, 2016 · 5 comments
Open

Python 3 #22

danielmcintosh1 opened this issue Mar 7, 2016 · 5 comments

Comments

@danielmcintosh1
Copy link
Collaborator

Latest update of Goldsberry is not compatible with Python 3.
@lutmingman
Copy link

lutmingman commented May 6, 2018 •
edited
Loading

I am getting an error like this:

line 40, in _get_nba_data
pull_url = cgi.urlparse.urljoin(base_url, self._url_modifier)
AttributeError: module 'cgi' has no attribute 'urlparse'

Is this the Python 3 problem mentioned above?

@danielmcintosh1
Copy link
Collaborator Author

Looks like it.
Reviewing the docs at https://docs.python.org/3/library/cgi.html you can see urlparse is no longer supported. If you find a suitable work around, feel free to create a PR

@lutmingman
Copy link

thanks for the quick response Daniel. will take a look

@Nussio777
Copy link

isnt urlparse just renamed to urllib.parse ?

@Odinidoer
Copy link

does anyone use it in 2018-10-10 11:26:45 in python3? i just get the raise
default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nussio777 @danielmcintosh1 @Odinidoer @lutmingman