Merge pull request #59 from boxuk/taxonomy-registration

jdamner · web-flow · commit 4bd79f257ab5 · 2024-07-16T10:16:36.000+01:00
[FEATURE] Add Taxonomy Registration to `post-types.json`.
diff --git a/packages/editor-tools/schema/post-type.schema.json b/packages/editor-tools/schema/post-type.schema.json
diff --git a/packages/editor-tools/src/PostTypes.php b/packages/editor-tools/src/PostTypes.php
@@ -41,6 +41,10 @@ public function register_post_types(): void {
 			return;
 		}
 
+		foreach ( $data['taxonomies'] ?? array() as $name => $args ) {
+			register_taxonomy( $name, array(), $args );
+		}
+
 		foreach ( $data['post_types'] ?? array() as $name => $args ) {
 			$args = wp_parse_args(
 				$args,
@@ -54,7 +58,7 @@ public function register_post_types(): void {
 			);
 
 			register_post_type( $name, $args ); // phpcs:ignore WordPress.NamingConventions.ValidPostTypeSlug.NotStringLiteral
-		}
+		}   
 	}
 
 	/**
diff --git a/packages/editor-tools/tests/TestPostTypes.php b/packages/editor-tools/tests/TestPostTypes.php
@@ -69,6 +69,21 @@ public function testRegisterPostTypes(): void {
 			->once()
 			->with( 'bar', $expected_parsed_json_with_defaults );
 
+		\WP_Mock::userFunction( 'register_taxonomy' )
+			->once()
+			->with( 
+				'example_category', 
+				array(), 
+				array(
+					'labels'  => array(
+						'name'          => 'TestName',
+						'singular_name' => 'TestName',
+					),
+					'public'  => true,
+					'rewrite' => array( 'slug' => 'example-category' ),
+				) 
+			);
+
 		// Short-circuit the test here as we'll test the blocks-to-template methods separately.
 		\WP_Mock::userFunction( 'is_admin' )
 			->twice()
diff --git a/packages/editor-tools/tests/fixtures/PostTypes/post-types.json b/packages/editor-tools/tests/fixtures/PostTypes/post-types.json
@@ -16,5 +16,17 @@
 			"menu_icon": "dashicons-admin-post",
 			"taxonomies": [ "category", "post_tag" ]
 		}
+	},
+	"taxonomies": {
+		"example_category": {
+			"labels": {
+				"name": "TestName",
+				"singular_name": "TestName"
+			},
+			"public": true,
+			"rewrite": {
+				"slug": "example-category"
+			}
+		}
 	}
 }
diff --git a/packages/iconography/config/material-symbols-outlined-filled.config.json b/packages/iconography/config/material-symbols-outlined-filled.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Outlined (Filled)",
 	"name": "boxuk/material-symbols-outlined-filled",
 	"tagName": "span",
diff --git a/packages/iconography/config/material-symbols-outlined.config.json b/packages/iconography/config/material-symbols-outlined.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Outlined",
 	"name": "boxuk/material-symbols-outlined",
 	"tagName": "span",
diff --git a/packages/iconography/config/material-symbols-rounded-filled.config.json b/packages/iconography/config/material-symbols-rounded-filled.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Rounded (Filled)",
 	"name": "boxuk/material-symbols-rounded-filled",
 	"tagName": "span",
diff --git a/packages/iconography/config/material-symbols-rounded.config.json b/packages/iconography/config/material-symbols-rounded.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Rounded",
 	"name": "boxuk/material-symbols-rounded",
 	"tagName": "span",
diff --git a/packages/iconography/config/material-symbols-sharp-filled.config.json b/packages/iconography/config/material-symbols-sharp-filled.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Sharp (Filled)",
 	"name": "boxuk/material-symbols-sharp-filled",
 	"tagName": "span",
diff --git a/packages/iconography/config/material-symbols-sharp.config.json b/packages/iconography/config/material-symbols-sharp.config.json
@@ -1,5 +1,5 @@
 {
-	"$schema": "../schema.json",
+	"$schema": "../schema/icon-config.json",
 	"title": "Sharp",
 	"name": "boxuk/material-symbols-sharp",
 	"tagName": "span",
diff --git a/packages/iconography/includes/ConfigurationParser.php b/packages/iconography/includes/ConfigurationParser.php
@@ -90,7 +90,7 @@ public function parse_config( string $file ) {
 	 * @return SchemaContract
 	 */
 	private function get_schema(): SchemaContract {
-		return Schema::import( plugin_dir_path( __DIR__ ) . '/schema.json' );
+		return Schema::import( plugin_dir_path( __DIR__ ) . '/schema/icon-config.json' );
 	}
 
 	/**
diff --git a/packages/iconography/schema/icon-config.json b/packages/iconography/schema/icon-config.json
diff --git a/packages/iconography/tests/fixtures/schema/icon-config.json b/packages/iconography/tests/fixtures/schema/icon-config.json

Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,17 @@`
`16`	`16`	`"menu_icon": "dashicons-admin-post",`
`17`	`17`	`"taxonomies": [ "category", "post_tag" ]`
`18`	`18`	`}`
	`19`	`+ },`
	`20`	`+ "taxonomies": {`
	`21`	`+ "example_category": {`
	`22`	`+ "labels": {`
	`23`	`+ "name": "TestName",`
	`24`	`+ "singular_name": "TestName"`
	`25`	`+ },`
	`26`	`+ "public": true,`
	`27`	`+ "rewrite": {`
	`28`	`+ "slug": "example-category"`
	`29`	`+ }`
	`30`	`+ }`
`19`	`31`	`}`
`20`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "$schema": "../schema.json",`
	`2`	`+ "$schema": "../schema/icon-config.json",`
`3`	`3`	`"title": "Outlined (Filled)",`
`4`	`4`	`"name": "boxuk/material-symbols-outlined-filled",`
`5`	`5`	`"tagName": "span",`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function parse_config( string $file ) {`
`90`	`90`	`* @return SchemaContract`
`91`	`91`	`*/`
`92`	`92`	`private function get_schema(): SchemaContract {`
`93`		`- return Schema::import( plugin_dir_path( __DIR__ ) . '/schema.json' );`
	`93`	`+ return Schema::import( plugin_dir_path( __DIR__ ) . '/schema/icon-config.json' );`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`/**`