Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bookmarks is sensitive to 'harakat' #10

Open
hwasiti opened this issue Dec 19, 2017 · 0 comments
Open

Search bookmarks is sensitive to 'harakat' #10

hwasiti opened this issue Dec 19, 2017 · 0 comments

Comments

@hwasiti
Copy link

hwasiti commented Dec 19, 2017

The book search is very nice. If search is done without arabic harakat, still it will find words with harakat, like Quran ayats usually written with harakat (e.g. fatha, kasra.... etc.)

However this is not the case when we search bookmarks.

Try this : highlight few Quran verses or any few words with harakat. Make search for a word in bookmarks by typing the search without harakat. It will not find it.

Can you please repeat the same corrections you did for book search to the search of bookmarks?

I tried to do it myself and make a pull request but I was lost, where is the correct place to repeat the corrections that you did for search to those for bookmark search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant