-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OOTB: package builds should not be aware of image features #3883
Labels
area/out-of-tree-builds
Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
type/enhancement
New feature or request
Comments
webern
added
type/enhancement
New feature or request
status/needs-triage
Pending triage or re-evaluation
area/out-of-tree-builds
Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
labels
Apr 9, 2024
This was referenced Apr 9, 2024
webern
changed the title
package builds should not be aware of image features
OOTB: package builds should not be aware of image features
Apr 9, 2024
This was referenced Apr 10, 2024
This was referenced Apr 24, 2024
We might have this done. grep spec files for image-features in packages. If we don't find any we should try building without passing image features to the package builds. |
Done in #4008. |
But... we should still delete the deprecated loading of the variant manifest here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/out-of-tree-builds
Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
type/enhancement
New feature or request
Some packages in Bottlerocket are built differently based on what image features are found in the variant Cargo.toml. We need packages to be unaware of variant and built the same for all variants.
In concert with bottlerocket-os/twoliter#193
These are the Bottlerocket packages affected:
The text was updated successfully, but these errors were encountered: