transfer: LegacyRemoteRepository.get_many() got an unexpected keyword argument 'raise_missing'

[bentolor]

Hi! I'm new to borg and started to toy around using with it. Thanks for this awesome piece of software!

I find the v2 features most and only compelling, hence started to experiment along my back-in-time infrastructure with an ARMv7 NAS as target.

I did the following:

Using borg v1.4 (client & server)

borg init --encryption=repokey borgbackup:backups/playground                                                                                                                       
borg create --stats borgbackup:backups/playground::docs ~/documents      

Switching to v2.0.0b19 (client & server)

borg repo-create -v --encryption repokey-chacha20-poly1305 --from-borg1 --other-repo ssh://borgbackup/backups/playground --repo ssh://borgbackup/backups/playgroundv2
borg transfer -v --other-repo ssh://borgbackup/backups/playground --from-borg1 --repo ssh://borgbackup/backups/playgroundv2 --upgrader From12To20 --compression zstd,9 --recompress --chunker-params buzhash64,19,23,21,4095 --dry-run

I don't understand if the --upgrader From12To20 is needed nor not. The error I receive is the same anyways:

Local Exception

Error:

TypeError: LegacyRemoteRepository.get_many() got an unexpected keyword argument 'raise_missing'

If reporting bugs, please include the following:

Traceback (most recent call last):
  File "/usr/lib/borgbackup2/borg/archiver/__init__.py", line 647, in main
    exit_code = archiver.run(args)
  File "/usr/lib/borgbackup2/borg/archiver/__init__.py", line 541, in run
    rc = func(args)
  File "/usr/lib/borgbackup2/borg/archiver/_common.py", line 211, in wrapper
    return method(self, args, **kwargs)
  File "/usr/lib/borgbackup2/borg/archiver/_common.py", line 141, in wrapper
    return method(self, args, repository=repository, cache=cache_, **kwargs)
  File "/usr/lib/borgbackup2/borg/archiver/transfer_cmd.py", line 206, in do_transfer
    for item in other_archive.iter_items():
                ~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/borgbackup2/borg/archive.py", line 648, in iter_items
    yield from self.pipeline.unpack_many(self.metadata.items, filter=lambda item: self.item_filter(item, filter))
  File "/usr/lib/borgbackup2/borg/archive.py", line 276, in unpack_many
    for data in self.fetch_many(ids, ro_type=ROBJ_ARCHIVE_STREAM, replacement_chunk=False):
                ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/borgbackup2/borg/archive.py", line 331, in fetch_many
    ids, sizes, self.repository.get_many(ids, is_preloaded=is_preloaded, raise_missing=False)
                ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: LegacyRemoteRepository.get_many() got an unexpected keyword argument 'raise_missing'

Platform: Linux neptun 6.17.0-6-generic #6-Ubuntu SMP PREEMPT_DYNAMIC Tue Oct  7 13:34:17 UTC 2025 x86_64
Linux: Unknown Linux
Borg: 2.0.0b19  Python: CPython 3.13.7 msgpack: 1.0.3 fuse: pyfuse3 3.4.0 [pyfuse3,llfuse]
PID: 70159  CWD: /home/ben
sys.argv: ['/usr/bin/borg', 'transfer', '-v', '--other-repo', 'ssh://borgbackup/backups/playground', '--from-borg1', '--repo', 'ssh://borgbackup/backups/playgroundv2', '--compression', 'zstd,9', '--recompress', '--chunker-params', 'buzhash64,19,23,21,4095', '--dry-run']
SSH_ORIGINAL_COMMAND: None

[ThomasWaldmann]

Looks like a bug, thanks for reporting it.

Note: we have a test for borg transfer with upgrade from 1.2 repo, but it is only executed with local repositories, so it did not catch this issue.

[ThomasWaldmann]

@bentolor can you apply the patch from #9200 locally and retry?

[bentolor]

Thanks @ThomasWaldmann for your quick reaction. I did a sudo mv legacyremote.py /usr/lib/borgbackup2/borg/legacyremote.py (client side only!) and re-executed the command:

Local Exception

Error:

AttributeError: 'NoneType' object has no attribute 'key'

If reporting bugs, please include the following:

Traceback (most recent call last):
  File "/usr/lib/borgbackup2/borg/archiver/__init__.py", line 647, in main
    exit_code = archiver.run(args)
  File "/usr/lib/borgbackup2/borg/archiver/__init__.py", line 541, in run
    rc = func(args)
  File "/usr/lib/borgbackup2/borg/archiver/_common.py", line 211, in wrapper
    return method(self, args, **kwargs)
  File "/usr/lib/borgbackup2/borg/archiver/_common.py", line 141, in wrapper
    return method(self, args, repository=repository, cache=cache_, **kwargs)
  File "/usr/lib/borgbackup2/borg/archiver/transfer_cmd.py", line 222, in do_transfer
    chunks, transfer, present = transfer_chunks(
                                ~~~~~~~~~~~~~~~^
        upgrader,
        ^^^^^^^^^
    ...<7 lines>...
        args.chunker_params,
        ^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/borgbackup2/borg/archiver/transfer_cmd.py", line 44, in transfer_chunks
    chunker = get_chunker(*chunker_params, key=archive.key, sparse=False)
                                               ^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'key'

Platform: Linux neptun 6.17.0-6-generic #6-Ubuntu SMP PREEMPT_DYNAMIC Tue Oct  7 13:34:17 UTC 2025 x86_64
Linux: Unknown Linux
Borg: 2.0.0b19  Python: CPython 3.13.7 msgpack: 1.0.3 fuse: pyfuse3 3.4.0 [pyfuse3,llfuse]
PID: 964324  CWD: /home/ben
sys.argv: ['/usr/bin/borg', 'transfer', '-v', '--other-repo', 'ssh://borgbackup/backups/playground', '--from-borg1', '--repo', 'ssh://borgbackup/backups/playgroundv2', '--upgrader', 'From12To20', '--compression', 'zstd,9', '--recompress', '--chunker-params', 'buzhash64,19,23,21,4095', '--dry-run']
SSH_ORIGINAL_COMMAND: None

[ThomasWaldmann]

replacing the whole file only works if it didn't change otherwise.

can you fetch and apply the patch?

[bentolor]

@ThomasWaldmann TIL: "Can I export a commit as a patch file from GitHub's web UI?"

$ sudo apt install borgbackup2 --reinstall  
$ sudo patch -p 3 -i 3cc891f1eead8399a8705c8c07a80b7e916d8563.diff /usr/lib/borgbackup2/borg/legacyremote.py 
patching file /usr/lib/borgbackup2/borg/legacyremote.py
Hunk #1 succeeded at 657 (offset -7 lines).
Hunk #2 succeeded at 741 (offset -7 lines).
Hunk #3 succeeded at 850 (offset -7 lines).
Hunk #4 succeeded at 873 (offset -7 lines).
$ borg transfer -v --other-repo ssh://borgbackup/backups/playground --from-borg1 --repo ssh://borgbackup/backups/playgroundv2 --upgrader From12To20 --compression zstd,9 --recompress --chunker-params buzhash64,19,23,21,4095 --dry-run

Same result.

Also just tried with a sudo rm /usr/lib/borgbackup2/borg/__pycache__/legacyremote.cpython-313.pyc ahead. No change. Don't know how python gracefully handles locally patched .py-files.

[ThomasWaldmann]

Hmm, have to do a local test setup and try it myself.

Our automated tests cover a lot of stuff, except that. :-|

[ThomasWaldmann]

@bentolor I have updated PR #9200:

• added a fix for the AttributeError
• added an automated test for that

If you want to try locally: you need the 2 fix patches, but you don't need the test patch from there.