You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've provided a bit of context in this issue which I originally reported on the premailer gem: premailer/premailer#434.
But to summarise:
we are generating some emails which use table layouts to present reports to users
some of these tables are large, e.g. a few hundred rows with a number of columns
a lot of the Bootstrap styles are of a form (e.g. h1 .badge > tbody > tr > td) which premailer is unable to optimise so the NokogiriFast adapter falls back to using nokogiri.
This results in very slow email compilation with periods of high CPU usage. Performance degrades with the size of the table in the email
It's difficult to see how to work around this, although open to suggestions! For now I think we are going to have to stop using bootstrap-email for at least some of our mailers.
This might also be causing, e.g. slow down in test suites depending on what layout/data people are using.
But this issue is almost certainly affecting anyone with tables in their email content.
Reviewing the bootstrap-email code I also see there's a final stage of beautifying the HTML. Is that needed, or could it be optional? Am wondering if there's other opportunities to optimise processing of large DOMs.
The text was updated successfully, but these errors were encountered:
What version of Bootstrap Email are you using?
v1.1.5
How are you compiling?
Rails
Code example
No response
Describe your issue
I've provided a bit of context in this issue which I originally reported on the
premailer
gem: premailer/premailer#434.But to summarise:
h1 .badge > tbody > tr > td
) whichpremailer
is unable to optimise so theNokogiriFast
adapter falls back to using nokogiri.It's difficult to see how to work around this, although open to suggestions! For now I think we are going to have to stop using bootstrap-email for at least some of our mailers.
This might also be causing, e.g. slow down in test suites depending on what layout/data people are using.
But this issue is almost certainly affecting anyone with tables in their email content.
Reviewing the bootstrap-email code I also see there's a final stage of beautifying the HTML. Is that needed, or could it be optional? Am wondering if there's other opportunities to optimise processing of large DOMs.
The text was updated successfully, but these errors were encountered: