Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated target names #4

Open
dutow opened this issue Oct 2, 2017 · 2 comments
Open

Deprecated target names #4

dutow opened this issue Oct 2, 2017 · 2 comments

Comments

@dutow
Copy link

dutow commented Oct 2, 2017

The project contains a large amount of deprecated names (policy CMP0037), such as windows/basic_handle.

This causes the VS2017 generator to fail with CMake 3.8.1 (also tested with 3.9):

CMake Error at bcm/share/bcm/cmake/BCMFuture.cmake:68 (_add_library):
  The target name "windows/basic_handle" is reserved or not valid for certain
  CMake features, such as generator expressions, and may result in undefined
  behavior.
Call Stack (most recent call first):
  bcm/share/bcm/cmake/BCMTest.cmake:104 (add_library)
  libs/asio/test/CMakeLists.txt:115 (bcm_test)

Setting the policy to the old version explicitly hides the problem for this generator:

cmake_policy(SET CMP0037 OLD)

I'm also not sure why it is an error by default - according to the CMake docs, this policy should be a warning by default, maybe it has something to do with the VS generator, as I see no similar problems on linux with Ninja.

@pfultz2
Copy link
Member

pfultz2 commented Oct 2, 2017

Thanks, yea there shouldn't target be with a / in the name. I will look over the name of tests to make sure they are all correct.

@Pwera
Copy link

Pwera commented Nov 19, 2017

Problem exist also under Ninja and MinGW generators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants