Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching in Github workflows #196

Open
gijsvl opened this issue Apr 21, 2022 · 0 comments
Open

Fix caching in Github workflows #196

gijsvl opened this issue Apr 21, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gijsvl
Copy link
Contributor

gijsvl commented Apr 21, 2022

Cache keys depend on the Cargo files, but we do not checkout the repo before we do the hashing, leading to a fixed cache-key. key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

Fix: checkout step should happen before cache step. (check all workflows)

@gijsvl gijsvl added the bug Something isn't working label Apr 21, 2022
@gijsvl gijsvl self-assigned this Apr 22, 2022
gijsvl added a commit that referenced this issue Apr 22, 2022
gijsvl added a commit that referenced this issue Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant